Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba665280 authored by Sneha Patil's avatar Sneha Patil
Browse files

DynamicsProcessing: Add test for MBC band config's pregain parameter 

This test validates that the calculated output dB of compressor and
expander with pregain is same at the test output dB.

Bug: 305866207
Test: atest VtsHalDynamicsProcessingTargetTest
Change-Id: I1fe2e46cfd3a26dc4f6d6f218712f4f81503881e
parent 3fd05f22

audio/aidl/vts/VtsHalDynamicsProcessingTest.cpp

+56 −0
Original line number Diff line number Diff line
@@ -39,6 +39,8 @@ using aidl::android::hardware::audio::effect::IFactory; 
using aidl::android::hardware::audio::effect::Parameter;

using android::hardware::audio::common::testing::detail::TestExecutionTracer;



constexpr int32_t kMinDataTestHalVersion = 3;



/**

 * Here we focus on specific parameter checking, general IEffect interfaces testing performed in

 * VtsAudioEffectTargetTest.
@@ -139,6 +141,8 @@ class DynamicsProcessingTestHelper : public EffectHelper { 
    void addLimiterConfig(const std::vector<DynamicsProcessing::LimiterConfig>& cfg);

    void addInputGain(const std::vector<DynamicsProcessing::InputGain>& inputGain);



    void checkHalVersion();



    static constexpr float kPreferredProcessingDurationMs = 10.0f;

    static constexpr int kBandCount = 5;

    static constexpr int kSamplingFrequency = 44100;
@@ -548,6 +552,13 @@ void DynamicsProcessingTestHelper::addInputGain( 
    mTags.push_back({DynamicsProcessing::inputGain, dp});

}



void DynamicsProcessingTestHelper::checkHalVersion() {

    if (int32_t version;

        mEffect->getInterfaceVersion(&version).isOk() && version < kMinDataTestHalVersion) {

        GTEST_SKIP() << "Skipping the data test for version: " << version << "\n";

    }

}



void fillLimiterConfig(std::vector<DynamicsProcessing::LimiterConfig>& limiterConfigList,

                       int channelIndex, bool enable, int linkGroup, float attackTime,

                       float releaseTime, float ratio, float threshold, float postGain) {
@@ -1541,6 +1552,51 @@ TEST_P(DynamicsProcessingMbcBandConfigDataTest, IncreasingPostGain) { 
    }

}



TEST_P(DynamicsProcessingMbcBandConfigDataTest, IncreasingPreGain) {

    /*

    Depending on the pregain values, samples undergo either compression or expansion process.

    At -6 dB input,

    - Expansion is expected at -60 dB,

    - Compression at 10, 34 and 60 dB

    - No compression or expansion at -34, -10, -1 dB.

     */

    std::vector<float> preGainDbValues = {-60, -34, -10, -1, 10, 34, 60};

    std::vector<float> output(mInput.size());

    float thresholdDb = -7;

    float noiseGateDb = -40;

    std::vector<float> ratioValues = {1, 1.5, 2, 2.5, 3};

    for (float ratio : ratioValues) {

        for (float preGainDb : preGainDbValues) {

            float expectedOutputDb;

            float inputWithPreGain = mInputDb + preGainDb;

            if (inputWithPreGain > thresholdDb) {

                SCOPED_TRACE("Compressor ratio: " + std::to_string(ratio));

                expectedOutputDb =

                        (inputWithPreGain - thresholdDb) / ratio + thresholdDb - preGainDb;

            } else if (inputWithPreGain < noiseGateDb) {

                SCOPED_TRACE("Expander ratio: " + std::to_string(ratio));

                expectedOutputDb =

                        (inputWithPreGain - noiseGateDb) * ratio + noiseGateDb - preGainDb;

            } else {

                expectedOutputDb = mInputDb;

            }

            cleanUpMbcConfig();

            for (int i = 0; i < mChannelCount; i++) {

                fillMbcBandConfig(mCfgs, i, thresholdDb, ratio /*compressor ratio*/, noiseGateDb,

                                  ratio /*expander ratio*/, 0 /*band index*/,

                                  2000 /*cutoffFrequency*/, preGainDb, kDefaultPostGainDb);

            }

            EXPECT_NO_FATAL_FAILURE(setMbcParamsAndProcess(output));

            if (!isAllParamsValid()) {

                continue;

            }

            float outputDb = calculateDb(output, kStartIndex);

            EXPECT_NEAR(outputDb, expectedOutputDb, kToleranceDb)

                    << "PreGain: " << preGainDb << ", OutputDb: " << outputDb;

        }

    }

}



INSTANTIATE_TEST_SUITE_P(DynamicsProcessingTest, DynamicsProcessingMbcBandConfigDataTest,

                         testing::ValuesIn(EffectFactoryHelper::getAllEffectDescriptors(

                                 IFactory::descriptor, getEffectTypeUuidDynamicsProcessing())),