Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6d11db7 authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge "BufferQueues: clean up BufferItemConsumer constructors" into main

parents 6b58b66d 3f580551
Loading
Loading
Loading
Loading
+4 −15
Original line number Diff line number Diff line
@@ -8715,25 +8715,14 @@ void CameraHidlTest::setupPreviewWindow(
    ASSERT_NE(nullptr, bufferItemConsumer);
    ASSERT_NE(nullptr, bufferHandler);

#if COM_ANDROID_GRAPHICS_LIBGUI_FLAGS(WB_CONSUMER_BASE_OWNS_BQ)
    *bufferItemConsumer = new BufferItemConsumer(
            GraphicBuffer::USAGE_HW_TEXTURE);  // Use GLConsumer default usage flags
#else
    sp<IGraphicBufferProducer> producer;
    sp<IGraphicBufferConsumer> consumer;
    BufferQueue::createBufferQueue(&producer, &consumer);
    *bufferItemConsumer = new BufferItemConsumer(consumer,
            GraphicBuffer::USAGE_HW_TEXTURE); //Use GLConsumer default usage flags
#endif  // COM_ANDROID_GRAPHICS_LIBGUI_FLAGS(WB_CONSUMER_BASE_OWNS_BQ)
    sp<Surface> surface;
    std::tie(*bufferItemConsumer, surface) =
            BufferItemConsumer::create(GraphicBuffer::USAGE_HW_TEXTURE);

    ASSERT_NE(nullptr, (*bufferItemConsumer).get());
    *bufferHandler = new BufferItemHander(*bufferItemConsumer);
    ASSERT_NE(nullptr, (*bufferHandler).get());
    (*bufferItemConsumer)->setFrameAvailableListener(*bufferHandler);
#if COM_ANDROID_GRAPHICS_LIBGUI_FLAGS(WB_CONSUMER_BASE_OWNS_BQ)
    sp<Surface> surface = (*bufferItemConsumer)->getSurface();
#else
    sp<Surface> surface = new Surface(producer);
#endif  // COM_ANDROID_GRAPHICS_LIBGUI_FLAGS(WB_CONSUMER_BASE_OWNS_BQ)
    sp<PreviewWindowCb> previewCb = new PreviewWindowCb(surface);

    auto rc = device->setPreviewWindow(previewCb);