Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aff4c556 authored by shrikar's avatar shrikar
Browse files

Update behavior of EV_PORT_LOCATION properties HAL docs in multiport EVs 

Bug: 316941251
Test: presubmit
Change-Id: I64f0e965a459c8f8ad0b3b23c635fbc38c600840
parent 379d7c1e

automotive/vehicle/aidl/emu_metadata/android.hardware.automotive.vehicle-types-meta.json

+2 −2
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ 
                    "PortLocationType"

                ],

                "data_enum": "PortLocationType",

                "description": "EV port location"

                "description": "EV port location\nThis property must communicate the location of the charging port on the EV using the PortLocationType enum. If there are multiple ports available on the vehicle, this property must return the port that allows the fastest charging. To communicate all port locations, use INFO_MULTI_EV_PORT_LOCATIONS."

            },

            {

                "name": "INFO_DRIVER_SEAT",
@@ -90,7 +90,7 @@ 
                    "PortLocationType"

                ],

                "data_enum": "PortLocationType",

                "description": "Multiple EV port locations\nImplement this property if the vehicle has multiple EV ports. Port locations are defined in PortLocationType. For example, a car has one port in front left and one port in rear left: int32Values[0] = PortLocationType::FRONT_LEFT int32Values[0] = PortLocationType::REAR_LEFT"

                "description": "Multiple EV port locations\nImplement this property if the vehicle has multiple EV ports. Port locations are defined in PortLocationType. For example, a car has one port in front left and one port in rear left: int32Values[0] = PortLocationType::FRONT_LEFT int32Values[1] = PortLocationType::REAR_LEFT\nIf only one port exists on the vehicle, this property's value should list just one element. See INFO_EV_PORT_LOCATION for describing just one port location."

            },

            {

                "name": "PERF_ODOMETER",

automotive/vehicle/aidl_property/android/hardware/automotive/vehicle/VehicleProperty.aidl

+9 −1
Original line number Diff line number Diff line
@@ -163,6 +163,11 @@ enum VehicleProperty { 
    /**

     * EV port location

     *

     * This property must communicate the location of the charging port on the EV using the

     * PortLocationType enum. If there are multiple ports available on the vehicle, this property

     * must return the port that allows the fastest charging. To communicate all port locations,

     * use INFO_MULTI_EV_PORT_LOCATIONS.

     *

     * @change_mode VehiclePropertyChangeMode.STATIC

     * @access VehiclePropertyAccess.READ

     * @data_enum PortLocationType
@@ -207,7 +212,10 @@ enum VehicleProperty { 
     * Port locations are defined in PortLocationType.

     * For example, a car has one port in front left and one port in rear left:

     *   int32Values[0] = PortLocationType::FRONT_LEFT

     *   int32Values[0] = PortLocationType::REAR_LEFT

     *   int32Values[1] = PortLocationType::REAR_LEFT

     *

     * If only one port exists on the vehicle, this property's value should list just one element.

     * See INFO_EV_PORT_LOCATION for describing just one port location.

     *

     * @change_mode VehiclePropertyChangeMode.STATIC

     * @access VehiclePropertyAccess.READ