Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adc87cba authored by Roshan Pius's avatar Roshan Pius
Browse files

WifiLegacyHal: Add missing ring buffer callback dereg 

Still figuring out how to send this data over the HIDL callback. Adding
this missing wrapper in legacy hal for now.

Bug:33638159
Test: Compiles
Change-Id: Ifce06a796d54e10c582b9896425899a45162a45f
parent 203cb031

wifi/1.0/default/wifi_legacy_hal.cpp

+13 −1
Original line number Diff line number Diff line
@@ -741,8 +741,20 @@ wifi_error WifiLegacyHal::registerRingBufferCallbackHandler( 
      on_user_data_callback(ring_name, buffer_vector, *status);

    }

  };

  return global_func_table_.wifi_set_log_handler(

  wifi_error status = global_func_table_.wifi_set_log_handler(

      0, wlan_interface_handle_, {onRingBufferData});

  if (status != WIFI_SUCCESS) {

    on_ring_buffer_data_internal_callback = nullptr;

  }

  return status;

}



wifi_error WifiLegacyHal::deregisterRingBufferCallbackHandler() {

  if (!on_ring_buffer_data_internal_callback) {

    return WIFI_ERROR_NOT_AVAILABLE;

  }

  on_ring_buffer_data_internal_callback = nullptr;

  return global_func_table_.wifi_reset_log_handler(0, wlan_interface_handle_);

}



std::pair<wifi_error, std::vector<wifi_ring_buffer_status>>

wifi/1.0/default/wifi_legacy_hal.h

+1 −0
Original line number Diff line number Diff line
@@ -192,6 +192,7 @@ class WifiLegacyHal { 
  std::pair<wifi_error, WakeReasonStats> getWakeReasonStats();

  wifi_error registerRingBufferCallbackHandler(

      const on_ring_buffer_data_callback& on_data_callback);

  wifi_error deregisterRingBufferCallbackHandler();

  std::pair<wifi_error, std::vector<wifi_ring_buffer_status>>

  getRingBuffersStatus();

  wifi_error startRingBufferLogging(const std::string& ring_name,