Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab222c63 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

audio: Allow onError callback in any state 

In practice, the AoC can crash while the stream is in
any state, thus this should be allowed for correct
handling of error conditions in the framework.

The list of states when `IStreamCallback.onError` can
be received is not enforced in VTS tests, thus no
test regressions are expected.

Bug: 339400414
Test: repro steps for simulating AoC crash in b/339400414
Change-Id: I9a52779f773307882109e159d715072de5af2ece
parent f12a0763

audio/aidl/android/hardware/audio/core/stream-out-async-sm.gv

+1 −3
Original line number Diff line number Diff line
@@ -51,9 +51,7 @@ digraph stream_out_async_state_machine { 
    DRAIN_PAUSED -> DRAINING [label="start"];         // consumer -> active

    DRAIN_PAUSED -> TRANSFER_PAUSED [label="burst"];  // producer -> active

    DRAIN_PAUSED -> IDLE [label="flush"];             // buffer is cleared

    IDLE -> ERROR [label="←IStreamCallback.onError"];

    DRAINING -> ERROR [label="←IStreamCallback.onError"];

    TRANSFERRING -> ERROR [label="←IStreamCallback.onError"];

    ANY_STATE -> ERROR [label="←IStreamCallback.onError"];

    ANY_STATE -> CLOSED [label="→IStream*.close"];

    CLOSED -> F;

}