Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7ea9ae1 authored by Ram Mohan M's avatar Ram Mohan M Committed by Pawin Vongmasa
Browse files

bug fix: add missing color formats to the check for valid formats 

Component can support 420PackedPlanar and 420PackedSemiPlanar as
their choice of color formats. The current test application can
fail in this case. This is corrected.

Test: make vts -j99 BUILD_GOOGLE_VTS=true TARGET_PRODUCT=aosp_arm64 \
&& vts-tradefed run commandAndExit vts \
--skip-all-system-status-check --primary-abi-only \
--skip-preconditions --module VtsHalMediaOmxV1_0Test -l INFO

Bug: 63796949

Change-Id: I38bbbb40b34dcdd4526e87708667dc116af900f1
parent df5dd34d

media/omx/1.0/vts/functional/video/VtsHalMediaOmxV1_0TargetVideoDecTest.cpp

+4 −2
Original line number Diff line number Diff line
@@ -814,7 +814,7 @@ void getDefaultColorFormat(sp<IOmxNode> omxNode, OMX_U32 kPortIndexOutput, 
    OMX_VIDEO_PARAM_PORTFORMATTYPE portFormat;

    *eColorFormat = OMX_COLOR_FormatUnused;

    portFormat.nIndex = 0;

    while (1) {

    while (portFormat.nIndex < 512) {

        status = getPortParam(omxNode, OMX_IndexParamVideoPortFormat,

                              kPortIndexOutput, &portFormat);

        if (status != ::android::hardware::media::omx::V1_0::Status::OK) break;
@@ -828,7 +828,9 @@ void getDefaultColorFormat(sp<IOmxNode> omxNode, OMX_U32 kPortIndexOutput, 
            break;

        }

        if (OMX_COLOR_FormatYUV420SemiPlanar == portFormat.eColorFormat ||

            OMX_COLOR_FormatYUV420Planar == portFormat.eColorFormat) {

            OMX_COLOR_FormatYUV420Planar == portFormat.eColorFormat ||

            OMX_COLOR_FormatYUV420PackedPlanar == portFormat.eColorFormat ||

            OMX_COLOR_FormatYUV420PackedSemiPlanar == portFormat.eColorFormat) {

            *eColorFormat = portFormat.eColorFormat;

            break;

        }