Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0c6d7d5 authored by Etan Cohen's avatar Etan Cohen
Browse files

[HAL] Invalidate chip before shutting down legacy HAL 

Change the order of shutdown to invalidate chips before
shutting down the legacy HAL. Allows pre-shutdown commands
to be sent down.

Bug: 63704506
Test: NAN tests passing
Test: full regression suite
Change-Id: I03d237d732b4e3482b1e1639848342dfdde9fcb7
parent 696cb630

wifi/1.1/default/wifi.cpp

+6 −6
Original line number Diff line number Diff line
@@ -126,6 +126,12 @@ WifiStatus Wifi::stopInternal() { 
    return createWifiStatus(WifiStatusCode::ERROR_NOT_AVAILABLE,

                            "HAL is stopping");

  }

  // Clear the chip object and its child objects since the HAL is now

  // stopped.

  if (chip_.get()) {

    chip_->invalidate();

    chip_.clear();

  }

  WifiStatus wifi_status = stopLegacyHalAndDeinitializeModeController();

  if (wifi_status.code == WifiStatusCode::SUCCESS) {

    for (const auto& callback : event_cb_handler_.getCallbacks()) {
@@ -140,12 +146,6 @@ WifiStatus Wifi::stopInternal() { 
      }

    }

  }

  // Clear the chip object and its child objects since the HAL is now

  // stopped.

  if (chip_.get()) {

    chip_->invalidate();

    chip_.clear();

  }

  LOG(INFO) << "Wifi HAL stopped";

  return wifi_status;

}