Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96828c48 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

audio: Update HIDL VTS VtsHalAudioPolicyV1_0TargetTest 

Match the change of 'ParameterManagerWrapper' from aosp/3438629.

Do not validate any vendor-side configs with HIDL XSD if it uses
AIDL HAL. This is because the XML config files can still be
present but they are not required to conform to HIDL XSD.

Note that the "hybrid mode" CAP should have a separate test,
and does not need to be covered by this test.

Bug: 379596346
Test: atest VtsHalAudioPolicyV1_0TargetTest
Change-Id: I7d435c6fecc36fd03779aad9c7148c9e9a6c848a
parent a8916d51

audio/policy/1.0/vts/functional/Android.bp

+8 −0
Original line number Diff line number Diff line
@@ -10,6 +10,11 @@ package { 


cc_test {

    name: "VtsHalAudioPolicyV1_0TargetTest",

    defaults: [

        "latest_android_hardware_audio_common_ndk_static",

        "latest_android_hardware_audio_core_ndk_static",

        "latest_android_media_audio_common_types_ndk_static",

    ],

    srcs: [

        "ValidateEngineConfiguration.cpp",

    ],
@@ -17,6 +22,7 @@ cc_test { 
        "libxml2",

        "liblog",

        "libmedia_helper",

        "libaidlvintf_gtest_helper",

        "libaudiopolicycapengine_config",

        "libaudiopolicycomponents",

        "libaudiopolicyengine_config",
@@ -33,6 +39,8 @@ cc_test { 
    ],

    shared_libs: [

        "libaudiofoundation",

        "libbinder_ndk",

        "libvintf",

    ],

    // Use test_config for vts suite.

    // TODO(b/146104851): Add auto-gen rules and remove it.

audio/policy/1.0/vts/functional/ValidateEngineConfiguration.cpp

+30 −7
Original line number Diff line number Diff line
@@ -16,6 +16,9 @@ 


#include <EngineConfig.h>

#include <ParameterManagerWrapper.h>

#include <aidl/Vintf.h>

#include <aidl/android/hardware/audio/core/IConfig.h>

#include <android/binder_manager.h>



#include <gtest/gtest.h>
@@ -34,12 +37,30 @@ static const std::string configurableSchemas = 
static const std::string configurableConfig =

        "parameter-framework/ParameterFrameworkConfigurationPolicy.xml";



static bool deviceUsesAidlHal() {

    using aidl::android::hardware::audio::core::IConfig;



    const auto configName = android::getAidlHalInstanceNames(IConfig::descriptor);

    if (!configName.empty()) {

        ndk::SpAIBinder binder =

                ndk::SpAIBinder(AServiceManager_waitForService(configName[0].c_str()));

        if (binder != nullptr) {

            std::shared_ptr<IConfig> configItf = IConfig::fromBinder(binder);

            return configItf != nullptr;

        }

    }

    return false;

}



/**

 * @brief TEST to ensure the audio policy engine configuration file is validating schemas.

 * Note: this configuration file is not mandatory, an hardcoded fallback is provided, so

 * it does not fail if not found.

 */

TEST(ValidateConfiguration, audioPolicyEngineConfiguration) {

    if (deviceUsesAidlHal()) {

        GTEST_SKIP() << "Device uses AIDL HAL, n-op.";

    }

    RecordProperty("description",

                   "Verify that the audio policy engine configuration file "

                   "is valid according to the schemas");
@@ -48,11 +69,12 @@ TEST(ValidateConfiguration, audioPolicyEngineConfiguration) { 
}



/**

 * @brief deviceUsesConfigurableEngine checks if the configuration file for

 * the engine presents on the device AND

 * for the configurable engine (aka Parameter-Framework top configuration file) presents.

 * @brief deviceUsesHidlConfigurableEngine checks if there is no AIDL HAL,

 * AND the configuration file for the engine presents on the device

 * AND for the configurable engine (aka Parameter-Framework top configuration file) presents.

 */

static bool deviceUsesConfigurableEngine() {

static bool deviceUsesHidlConfigurableEngine() {

    if (deviceUsesAidlHal()) return false;

    return android::hardware::audio::common::test::utility::validateXmlMultipleLocations<true>(

                   "", "", "", config.c_str(), android::audio_get_configuration_paths(),

                   schema.c_str()) &&
@@ -62,8 +84,8 @@ static bool deviceUsesConfigurableEngine() { 
}



TEST(ValidateConfiguration, audioPolicyEngineConfigurable) {

    if (!deviceUsesConfigurableEngine()) {

        GTEST_SKIP() << "Device using legacy engine without parameter-framework, n-op.";

    if (!deviceUsesHidlConfigurableEngine()) {

        GTEST_SKIP() << "Device uses AIDL HAL or legacy engine without parameter-framework, n-op.";

    }

    RecordProperty("description",

                   "Verify that the audio policy engine PFW configuration files "
@@ -78,7 +100,8 @@ TEST(ValidateConfiguration, audioPolicyEngineConfigurable) { 
        ASSERT_EQ(result.nbSkippedElement, 0) << "skipped %zu elements " << result.nbSkippedElement;



        std::unique_ptr<android::audio_policy::ParameterManagerWrapper> policyParameterMgr(

                new android::audio_policy::ParameterManagerWrapper(validateSchema, schemasUri));

                new android::audio_policy::ParameterManagerWrapper(

                        true /*useLegacyConfigurationFile*/, validateSchema, schemasUri));

        ASSERT_NE(nullptr, policyParameterMgr) << "failed to create Audio Policy Engine PFW";



        // Load the criterion types and criteria