Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 918a6a5c authored by Peter Yoon's avatar Peter Yoon
Browse files

audio: Allow Module subclasses to customize Configuration 

When a vendor HAL reuses libaudioserviceexampleimpl,
a subclass of Module cannot change Configuration.

This change adds virtual method Module::initializeConfig(),
then a vendor HAL can override it to load custom Configuration.

Test: atest VtsHalAudioCoreTargetTest
Change-Id: I63fa8d70f3c4e13c8938070ee5431ebefd36bb58
parent f0ad731b

audio/aidl/default/Module.cpp

+20 −14
Original line number Diff line number Diff line
@@ -286,22 +286,28 @@ std::set<int32_t> Module::portIdsFromPortConfigIds(C portConfigIds) { 
    return result;

}



internal::Configuration& Module::getConfig() {

    if (!mConfig) {

        switch (mType) {

std::unique_ptr<internal::Configuration> Module::initializeConfig() {

    std::unique_ptr<internal::Configuration> config;

    switch (getType()) {

        case Type::DEFAULT:

                mConfig = std::move(internal::getPrimaryConfiguration());

            config = std::move(internal::getPrimaryConfiguration());

            break;

        case Type::R_SUBMIX:

                mConfig = std::move(internal::getRSubmixConfiguration());

            config = std::move(internal::getRSubmixConfiguration());

            break;

        case Type::STUB:

                mConfig = std::move(internal::getStubConfiguration());

            config = std::move(internal::getStubConfiguration());

            break;

        case Type::USB:

                mConfig = std::move(internal::getUsbConfiguration());

            config = std::move(internal::getUsbConfiguration());

            break;

    }

    return config;

}



internal::Configuration& Module::getConfig() {

    if (!mConfig) {

        mConfig = std::move(initializeConfig());

    }

    return *mConfig;

}

audio/aidl/default/include/core-impl/Module.h

+2 −0
Original line number Diff line number Diff line
@@ -182,6 +182,7 @@ class Module : public BnModule { 
            const ::aidl::android::media::audio::common::AudioPort& audioPort, bool connected);

    virtual ndk::ScopedAStatus onMasterMuteChanged(bool mute);

    virtual ndk::ScopedAStatus onMasterVolumeChanged(float volume);

    virtual std::unique_ptr<internal::Configuration> initializeConfig();



    // Utility and helper functions accessible to subclasses.

    void cleanUpPatch(int32_t patchId);
@@ -202,6 +203,7 @@ class Module : public BnModule { 
    bool getMicMute() const { return mMicMute; }

    const Patches& getPatches() const { return mPatches; }

    const Streams& getStreams() const { return mStreams; }

    Type getType() const { return mType; }

    bool isMmapSupported();

    template <typename C>

    std::set<int32_t> portIdsFromPortConfigIds(C portConfigIds);