Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fd2a85b authored by chrisweir's avatar chrisweir Committed by Chris Weir
Browse files

Clean up TODOs 

Squeegee supports Android now, so I'm cleaning up my TODOs.

Bug: 144458917
Bug: 144775286
Test: Only changes to comments

Change-Id: Ifd9907ba944759d4d5b36bce92f6bd11b5bb74e7
(cherry picked from commit 1ab35548)
parent 0df912df

automotive/can/1.0/default/CanBus.cpp

+0 −2
Original line number Diff line number Diff line
@@ -226,7 +226,6 @@ bool CanBus::down() { 
 * \param flag bool object from CanMessage object

 */

static bool satisfiesFilterFlag(FilterFlag filterFlag, bool flag) {

    // TODO(b/144458917) add testing for this to VTS tests

    if (filterFlag == FilterFlag::DONT_CARE) return true;

    if (filterFlag == FilterFlag::SET) return flag;

    if (filterFlag == FilterFlag::NOT_SET) return !flag;
@@ -302,7 +301,6 @@ void CanBus::onRead(const struct canfd_frame& frame, std::chrono::nanoseconds ti 
    if ((frame.can_id & CAN_ERR_FLAG) != 0) {

        // error bit is set

        LOG(WARNING) << "CAN Error frame received";

        // TODO(b/144458917) consider providing different values for isFatal, depending on error

        notifyErrorListeners(parseErrorFrame(frame), false);

        return;

    }

automotive/can/1.0/default/CanBusSlcan.cpp

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ ICanController::Result CanBusSlcan::preUp() { 
        return ICanController::Result::UNKNOWN_ERROR;

    }



    // set open flag TODO: also support listen only

    // TODO(b/144775286): set open flag & support listen only

    if (write(mFd.get(), slcanprotocol::kOpenCommand.c_str(),

              slcanprotocol::kOpenCommand.length()) <= 0) {

        LOG(ERROR) << "Failed to set open flag: " << strerror(errno);