Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bdbf00a authored by Emilian Peev's avatar Emilian Peev
Browse files

Camera: Remove binderized todo comment 

The camera test cases already already run in binderized mode
for any devices that have this mode enabled.
Additionally remove the missing camera device todo as well.
This should be handled by the VTS infrastructure.
Camera provider service constant updated as well.

Bug: 38137798
Test: VtsHalCameraProviderV2_4TargetTest
Change-Id: I45ddf224dd4dac3ddfbbd751fa297e4631283537
parent 33b92997

camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp

+2 −4
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ using ::android::hardware::camera::device::V1_0::ICameraDevicePreviewCallback; 
using ::android::hardware::camera::device::V1_0::FrameCallbackFlag;

using ::android::hardware::camera::device::V1_0::HandleTimestampMessage;



const char kCameraPassthroughServiceName[] = "legacy/0";

const char kCameraLegacyServiceName[] = "legacy/0";

const uint32_t kMaxPreviewWidth = 1920;

const uint32_t kMaxPreviewHeight = 1080;

const uint32_t kMaxVideoWidth = 4096;
@@ -185,9 +185,7 @@ private: 
};



void CameraHidlEnvironment::SetUp() {

    // TODO: test the binderized mode

    mProvider = ::testing::VtsHalHidlTargetTestBase::getService<ICameraProvider>(kCameraPassthroughServiceName);

    // TODO: handle the device doesn't have any camera case

    mProvider = ::testing::VtsHalHidlTargetTestBase::getService<ICameraProvider>(kCameraLegacyServiceName);

    ALOGI_IF(mProvider, "provider is not nullptr, %p", mProvider.get());

    ASSERT_NE(mProvider, nullptr);

}