Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8922e560 authored by Harpreet \"Eli\" Sangha's avatar Harpreet \"Eli\" Sangha
Browse files

vibrator: aidl: Remove Output Checks on Error 



VTS tests should treat output values as uninitialized when the returns
status is not OK.

Bug: 151174217
Test: Ran on Flame and Walleye
Signed-off-by: default avatarHarpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: I8a3fa77d35265b6dd371caace18ffb810e83a72f
parent 9aa930f8

vibrator/aidl/vts/VtsHalVibratorTargetTest.cpp

+0 −3
Original line number Original line Diff line number Diff line
@@ -128,7 +128,6 @@ TEST_P(VibratorAidl, ValidateEffect) { 
            } else {

            } else {

                EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION)

                EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION)

                        << toString(effect) << " " << toString(strength);

                        << toString(effect) << " " << toString(strength);

                EXPECT_EQ(lengthMs, 0);

            }

            }

        }

        }

    }

    }
@@ -157,7 +156,6 @@ TEST_P(VibratorAidl, ValidateEffectWithCallback) { 
                EXPECT_GT(lengthMs, 0);

                EXPECT_GT(lengthMs, 0);

            } else {

            } else {

                EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION);

                EXPECT_EQ(status.exceptionCode(), Status::EX_UNSUPPORTED_OPERATION);

                EXPECT_EQ(lengthMs, 0);

            }

            }





            if (!status.isOk()) continue;

            if (!status.isOk()) continue;
@@ -177,7 +175,6 @@ TEST_P(VibratorAidl, ValidateEffectWithCallbackNotSupported) { 
            int lengthMs;

            int lengthMs;

            Status status = vibrator->perform(effect, strength, callback, &lengthMs);

            Status status = vibrator->perform(effect, strength, callback, &lengthMs);

            EXPECT_EQ(Status::EX_UNSUPPORTED_OPERATION, status.exceptionCode());

            EXPECT_EQ(Status::EX_UNSUPPORTED_OPERATION, status.exceptionCode());

            EXPECT_EQ(lengthMs, 0);

        }

        }

    }

    }

}

}