Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88e871b6 authored by Alec Mouri's avatar Alec Mouri
Browse files

Actually add DimmingStage to client target properties

This change was missed while cherry-picking
I5675c16f0895f9958e3bee3ee4c85df8937ecdb7 due to merge conflicts.
So...actually merge this.

Bug: 218954037
Test: builds
Change-Id: Idb3a518f7dfd4f4fd598672ee709ccd5b1f3f06a
parent 194a26f5
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -37,4 +37,5 @@ parcelable ClientTargetPropertyWithBrightness {
  long display;
  android.hardware.graphics.composer3.ClientTargetProperty clientTargetProperty;
  float brightness;
  android.hardware.graphics.composer3.DimmingStage dimmingStage;
}
+15 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@
package android.hardware.graphics.composer3;

import android.hardware.graphics.composer3.ClientTargetProperty;
import android.hardware.graphics.composer3.DimmingStage;

@VintfStability
parcelable ClientTargetPropertyWithBrightness {
@@ -35,4 +36,18 @@ parcelable ClientTargetPropertyWithBrightness {
     * The brightness as described in CommandResultPayload.clientTargetProperty
     */
    float brightness;

    /**
     * The stage in which dimming operations should be performed when compositing
     * the client target.
     * Note that with a COLORIMETRIC RenderIntent, DimmingSpace must be LINEAR. That is, dimming
     * is defined to occur in linear space.
     * However, some composer implementations may, with other vendor-defined RenderIntents,
     * configure their hardware such as image quality adjustments is intended to occur after
     * composition. In this scenario, if the dimming operation were applied in linear space,
     * then the resulting dimming operation may comepl those image quality adjustments to
     * incorrectly alter the gamma curve. To avoid this issue, those implementations must opt to
     * dim in gamma space.
     */
    DimmingStage dimmingStage;
}