Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 879cd899 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Resolve TODOs in Vehicle HAL interface"

parents 34279488 03dddfe4

vehicle/2.0/IVehicle.hal

+0 −3
Original line number Diff line number Diff line
@@ -99,9 +99,6 @@ interface IVehicle { 
   * primitives used (such as mutex locks or semaphores) must be acquired

   * with a timeout.

   *

   * TODO(pavelm): we cannot use handle here due to Java compatibility, it's

   * better to pass file descriptor and write debug data directly in vehicle HAL

   * rather than passing back a string.

   */

  debugDump() generates (string s);

};

vehicle/2.0/types.hal

+1 −2
Original line number Diff line number Diff line
@@ -332,7 +332,6 @@ enum VehicleProperty: int32_t { 
     *

     * @change_mode VehiclePropertyChangeMode:ON_CHANGE

     * @access VehiclePropertyAccess:READ_WRITE

     * @data_enum TODO

     * @allow_out_of_range_value : OFF

     */

    HVAC_FAN_SPEED = (
@@ -346,7 +345,7 @@ enum VehicleProperty: int32_t { 
     *

     * @change_mode VehiclePropertyChangeMode:ON_CHANGE

     * @access VehiclePropertyAccess:READ_WRITE

     * @data_enum TODO

     * @data_enum VehicleHvacFanDirection

     * @allow_out_of_range_value : OFF

     */

    HVAC_FAN_DIRECTION = (