Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86fefab5 authored by Chih-hung Hsieh's avatar Chih-hung Hsieh Committed by android-build-merger
Browse files

Merge "Fix performance-for-range-copy warnings" am: d01f7050 

am: 51e835ce

Change-Id: I1b0a9bf419cb3a4df2aacc3b37bf28e42fa2a103
parents 64ec2acd 51e835ce

automotive/vehicle/2.0/default/common/src/VehicleHalManager.cpp

+2 −2
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ void VehicleHalManager::onHalPropertySetError(StatusCode errorCode, 
    const auto& clients =

        mSubscriptionManager.getSubscribedClients(property, SubscribeFlags::EVENTS_FROM_CAR);



    for (auto client : clients) {

    for (const auto& client : clients) {

        client->getCallback()->onPropertySetError(errorCode, property, areaId);

    }

}
@@ -312,7 +312,7 @@ bool VehicleHalManager::checkReadPermission(const VehiclePropConfig &config) con 
void VehicleHalManager::handlePropertySetEvent(const VehiclePropValue& value) {

    auto clients =

        mSubscriptionManager.getSubscribedClients(value.prop, SubscribeFlags::EVENTS_FROM_ANDROID);

    for (auto client : clients) {

    for (const auto& client : clients) {

        client->getCallback()->onPropertySet(value);

    }

}

automotive/vehicle/2.0/default/tests/SubscriptionManager_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ public: 
    static std::list<sp<IVehicleCallback>> extractCallbacks(

            const std::list<sp<HalClient>>& clients) {

        std::list<sp<IVehicleCallback>> callbacks;

        for (auto c : clients) {

        for (const auto& c : clients) {

            callbacks.push_back(c->getCallback());

        }

        return callbacks;

camera/device/3.2/default/CameraDevice.cpp

+1 −1
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ Return<void> CameraDevice::open(const sp<ICameraDeviceCallback>& callback, open_ 
            session->getInterface()->interfaceChain([](

                ::android::hardware::hidl_vec<::android::hardware::hidl_string> interfaceChain) {

                    ALOGV("Session interface chain:");

                    for (auto iface : interfaceChain) {

                    for (const auto& iface : interfaceChain) {

                        ALOGV("  %s", iface.c_str());

                    }

                });

camera/device/3.3/default/CameraDevice.cpp

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ sp<V3_2::implementation::CameraDeviceSession> CameraDevice::createSession(camera 
        session->getInterface()->interfaceChain([](

            ::android::hardware::hidl_vec<::android::hardware::hidl_string> interfaceChain) {

                ALOGV("Session interface chain:");

                for (auto iface : interfaceChain) {

                for (const auto& iface : interfaceChain) {

                    ALOGV("  %s", iface.c_str());

                }

            });

camera/device/3.4/default/CameraDevice.cpp

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ sp<V3_2::implementation::CameraDeviceSession> CameraDevice::createSession(camera 
        session->getInterface()->interfaceChain([](

            ::android::hardware::hidl_vec<::android::hardware::hidl_string> interfaceChain) {

                ALOGV("Session interface chain:");

                for (auto iface : interfaceChain) {

                for (const auto& iface : interfaceChain) {

                    ALOGV("  %s", iface.c_str());

                }

            });