Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83ea817a authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge changes Iee37bb97,If7c549b8 

* changes:
  Adjust IMapperMetadataTypes.h to match gralloc4 encoding
  Add some more tests & tweak spec around SMPTE2094-40
parents 0f4d6896 0e4732c1

graphics/common/aidl/android/hardware/graphics/common/StandardMetadataType.aidl

+3 −3
Original line number Diff line number Diff line
@@ -22,9 +22,9 @@ package android.hardware.graphics.common; 
 * This is an enum that defines the common types of gralloc 4 buffer metadata. The comments for

 * each enum include a description of the metadata that is associated with the type.

 *

 * IMapper@4.x must support getting the following standard buffer metadata types, with the exception

 * of SMPTE 2094-10 metadata. IMapper@4.x may support setting these standard buffer metadata types

 * as well.

 * IMapper@4.x & later must support getting the following standard buffer metadata types, with the

 * exception of SMPTE 2094-10 and SMPTE 2094-40 metadata. IMapper@4.x & later may support setting

 * these standard buffer metadata types as well.

 *

 * When encoding these StandardMetadataTypes into a byte stream, the associated MetadataType is

 * is first encoded followed by the StandardMetadataType value. The MetadataType is encoded by

graphics/mapper/stable-c/Android.bp

+4 −0
Original line number Diff line number Diff line
@@ -61,6 +61,10 @@ cc_test { 
    srcs: [

        "implutils/impltests.cpp",

    ],

    shared_libs: [

        "libgralloctypes",

        "libhidlbase",

    ],

    visibility: [":__subpackages__"],

    cpp_std: "experimental",

}

graphics/mapper/stable-c/implutils/impltests.cpp

+290 −70

File changed.

Preview size limit exceeded, changes collapsed.

graphics/mapper/stable-c/implutils/include/android/hardware/graphics/mapper/utils/IMapperMetadataTypes.h

+86 −39

File changed.

Preview size limit exceeded, changes collapsed.

graphics/mapper/stable-c/include/android/hardware/graphics/mapper/IMapper.h

+12 −10
Original line number Diff line number Diff line
@@ -509,11 +509,12 @@ typedef struct AIMapperV5 { 
     * particular Metadata field.

     *

     * The framework will attempt to set the following StandardMetadataType

     * values: DATASPACE, SMPTE2086, CTA861_3, SMPTE2094_40 and BLEND_MODE.

     * We require everyone to support setting those fields. If a device's Composer

     * implementation supports a field, it should be supported here. Over time these

     * metadata fields will be moved out of Composer/BufferQueue/etc. and into the

     * buffer's Metadata fields.

     * values: DATASPACE, SMPTE2086, CTA861_3, and BLEND_MODE.

     * We require everyone to support setting those fields. Framework will also attempt to set

     * SMPTE2094_40 and SMPTE2094_10 if available, and it is required to support setting those

     * if it is possible to get them. If a device's Composer implementation supports a field,

     * it should be supported here. Over time these metadata fields will be moved out of

     * Composer/BufferQueue/etc. and into the buffer's Metadata fields.

     *

     * @param buffer Buffer receiving desired metadata

     * @param metadataType MetadataType for the metadata value being set
@@ -546,11 +547,12 @@ typedef struct AIMapperV5 { 
     * particular Metadata field.

     *

     * The framework will attempt to set the following StandardMetadataType

     * values: DATASPACE, SMPTE2086, CTA861_3, SMPTE2094_40 and BLEND_MODE.

     * We require everyone to support setting those fields. If a device's Composer

     * implementation supports a field, it should be supported here. Over time these

     * metadata fields will be moved out of Composer/BufferQueue/etc. and into the

     * buffer's Metadata fields.

     * values: DATASPACE, SMPTE2086, CTA861_3, and BLEND_MODE.

     * We require everyone to support setting those fields. Framework will also attempt to set

     * SMPTE2094_40 and SMPTE2094_10 if available, and it is required to support setting those

     * if it is possible to get them. If a device's Composer implementation supports a field,

     * it should be supported here. Over time these metadata fields will be moved out of

     * Composer/BufferQueue/etc. and into the buffer's Metadata fields.

     *

     * @param buffer Buffer receiving desired metadata

     * @param standardMetadataType StandardMetadataType for the metadata value being set