Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f326f9f authored by Etan Cohen's avatar Etan Cohen
Browse files

[WIFI][VTS] Don't call RequestDriverDebugDump API if not supported 

The RequestDriverDebugDump API has a capability bit indicating if
supported on device. Calling if not supported should additionally
return ERROR_NOT_SUPPORTED - but does not today. This is arguably
not a valid issue - should not call API if already known not to be
supported.

Remove test for this (questionable) condition until decide on proper
semantics.

Bug: 36562856
Test: test passes
Change-Id: Ic8a1c8b5f77a1b1767c0efc9735731084dfde7cc
parent 4b132a9d

wifi/1.0/vts/functional/wifi_chip_hidl_test.cpp

+4 −2
Original line number Diff line number Diff line
@@ -235,8 +235,10 @@ TEST_F(WifiChipHidlTest, RequestDriverDebugDump) { 
    if (caps & IWifiChip::ChipCapabilityMask::DEBUG_MEMORY_DRIVER_DUMP) {

        EXPECT_EQ(WifiStatusCode::SUCCESS, status_and_driver_dump.first.code);

    } else {

        EXPECT_EQ(WifiStatusCode::ERROR_NOT_SUPPORTED,

                  status_and_driver_dump.first.code);

      // API semantics (today) are such that function cannot be called if not capable!

      //

      //  EXPECT_EQ(WifiStatusCode::ERROR_NOT_SUPPORTED,

      //            status_and_driver_dump.first.code);

    }

}