Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b6951ee authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

audio: Abort on data FMQ pointer corruption 

Issue a fatal error when the data FMQ detects internal pointers
corruption. This condition indicates some low level problems
and should be diagnosed as fast as possible.

Bug: 338974476
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I962eba620149c7169f0f0a2dad4c4064232966d7
parent 0ed9be7f

audio/aidl/default/Stream.cpp

+9 −2
Original line number Diff line number Diff line
@@ -315,7 +315,11 @@ StreamInWorkerLogic::Status StreamInWorkerLogic::cycle() { 
bool StreamInWorkerLogic::read(size_t clientSize, StreamDescriptor::Reply* reply) {

    ATRACE_CALL();

    StreamContext::DataMQ* const dataMQ = mContext->getDataMQ();

    const size_t byteCount = std::min({clientSize, dataMQ->availableToWrite(), mDataBufferSize});

    StreamContext::DataMQ::Error fmqError = StreamContext::DataMQ::Error::NONE;

    std::string fmqErrorMsg;

    const size_t byteCount = std::min(

            {clientSize, dataMQ->availableToWrite(&fmqError, &fmqErrorMsg), mDataBufferSize});

    CHECK(fmqError == StreamContext::DataMQ::Error::NONE) << fmqErrorMsg;

    const bool isConnected = mIsConnected;

    const size_t frameSize = mContext->getFrameSize();

    size_t actualFrameCount = 0;
@@ -587,7 +591,10 @@ StreamOutWorkerLogic::Status StreamOutWorkerLogic::cycle() { 
bool StreamOutWorkerLogic::write(size_t clientSize, StreamDescriptor::Reply* reply) {

    ATRACE_CALL();

    StreamContext::DataMQ* const dataMQ = mContext->getDataMQ();

    const size_t readByteCount = dataMQ->availableToRead();

    StreamContext::DataMQ::Error fmqError = StreamContext::DataMQ::Error::NONE;

    std::string fmqErrorMsg;

    const size_t readByteCount = dataMQ->availableToRead(&fmqError, &fmqErrorMsg);

    CHECK(fmqError == StreamContext::DataMQ::Error::NONE) << fmqErrorMsg;

    const size_t frameSize = mContext->getFrameSize();

    bool fatal = false;

    int32_t latency = mContext->getNominalLatencyMs();