Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78836599 authored by Mikhail Naganov's avatar Mikhail Naganov Committed by android-build-merger
Browse files

Audio HAL: Fix UAF if the effect is removed after close

am: 532240f4

Change-Id: I3a6ce3da68a1be76858f936d437860503b93c03b
parents 7216c1bb 532240f4
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -713,7 +713,10 @@ Return<Result> Effect::close() {
#elif MAJOR_VERSION >= 6
    // No need to join the processing thread, it is part of the API contract that the client
    // must finish processing before closing the effect.
    return analyzeStatus("EffectRelease", "", sContextCallFunction, EffectRelease(mHandle));
    Result retval =
            analyzeStatus("EffectRelease", "", sContextCallFunction, EffectRelease(mHandle));
    EffectMap::getInstance().remove(mHandle);
    return retval;
#endif
}