Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7400d1c5 authored by Scott Randolph's avatar Scott Randolph
Browse files

Update VHAL comments to clarify useage 

Window position and motion updated.
Also added comments calling out explicit temperature units.

Test:  Build mojave
Change-Id: If283a5f0de1ff6e9b2d3c21bcd652de55e2d7046
Bug: 77983671
parent 0477651e

automotive/vehicle/2.0/types.hal

+22 −18
Original line number Diff line number Diff line
@@ -654,7 +654,8 @@ enum VehicleProperty : int32_t { 
     * HVAC current temperature.

     *

     * @change_mode VehiclePropertyChangeMode:ON_CHANGE

     * @access VehiclePropertyAccess:READ_WRITE

     * @access VehiclePropertyAccess:READ

     * @unit VehicleUnit:CELSIUS

     */

    HVAC_TEMPERATURE_CURRENT = (

        0x0502
@@ -667,6 +668,7 @@ enum VehicleProperty : int32_t { 
     *

     * @change_mode VehiclePropertyChangeMode:ON_CHANGE

     * @access VehiclePropertyAccess:READ_WRITE

     * @unit VehicleUnit:CELSIUS

     */

    HVAC_TEMPERATURE_SET = (

        0x0503
@@ -791,7 +793,7 @@ enum VehicleProperty : int32_t { 
        | VehicleArea:SEAT),



    /**

     * Seat temperature

     * Seat heating/cooling

     *

     * Negative values indicate cooling.

     * 0 indicates off.
@@ -847,9 +849,11 @@ enum VehicleProperty : int32_t { 
    /**

     * Temperature units for display

     *

     * Indicates whether the temperature is in Celsius, Fahrenheit, or a

     * different unit from VehicleUnit enum.  This parameter MAY be used for

     * displaying any HVAC temperature in the system.

     * Indicates whether the vehicle is displaying temperature to the user as

     * Celsius or Fahrenheit.

     * This parameter MAY be used for displaying any HVAC temperature in the system.

     * Values must be one of VehicleUnit::CELSIUS or VehicleUnit::FAHRENHEIT

     * Note that internally, all temperatures are represented in floating point Celsius.

     *

     * @change_mode VehiclePropertyChangeMode:ON_CHANGE

     * @access VehiclePropertyAccess:READ_WRITE
@@ -1629,8 +1633,8 @@ enum VehicleProperty : int32_t { 
    /**

     * Window Position

     *

     * Max = window up / closed

     * Min = window down / open

     * Min = window up / closed

     * Max = window down / open

     *

     * For a window that may open out of plane (i.e. vent mode of sunroof) this

     * parameter will work with negative values as follows:
@@ -1652,9 +1656,9 @@ enum VehicleProperty : int32_t { 
    /**

     * Window Move

     *

     * Max = window up / closed

     * Min = window down / open

     * Magnitude denotes relative speed.  I.e. +2 is faster than +1 in raising

     * Max = Open the window as fast as possible

     * Min = Close the window as fast as possible

     * Magnitude denotes relative speed.  I.e. +2 is faster than +1 in closing

     * the window.

     *

     * For a window that may open out of plane (i.e. vent mode of sunroof) this
@@ -1668,7 +1672,7 @@ enum VehicleProperty : int32_t { 
     *   Max = close the vent, automatically stop when vent is closed.

     *   Min = open the vent further, automatically stop when vent is fully open.

     *

     * If window is in the closed position:

     * If sunroof is in the closed position:

     *   Max = open the sunroof, automatically stop when sunroof is fully open.

     *   Min = open the vent, automatically stop when vent is fully open.

     *

current.txt

+1 −1
Original line number Diff line number Diff line
@@ -297,7 +297,7 @@ f2904a4c108ad1b93eb2fa4e43b82bd01ce1ff26156316e49d1d9fc80dfecaad android.hardwar 
3b17c1fdfc389e0abe626c37054954b07201127d890c2bc05d47613ec1f4de4f android.hardware.automotive.evs@1.0::types

b3caf524c46a47d67e6453a34419e1881942d059e146cda740502670e9a752c3 android.hardware.automotive.vehicle@2.0::IVehicle

7ce8728b27600e840cacf0a832f6942819fe535f9d3797ae052d5eef5065921c android.hardware.automotive.vehicle@2.0::IVehicleCallback

848fb32d5ca79dd527d966e67c0af5874b6d7b361246b491e315cf7dea7888ab android.hardware.automotive.vehicle@2.0::types

2e1815967a3e3278a7f304ed7efc04fbc56d0bb65b3126248c3a0d515b93f63d android.hardware.automotive.vehicle@2.0::types

32cc50cc2a7658ec613c0c2dd2accbf6a05113b749852879e818b8b7b438db19 android.hardware.bluetooth.a2dp@1.0::IBluetoothAudioHost

ff4be64d7992f8bec97dff37f35450e79b3430c61f85f54322ce45bef229dc3b android.hardware.bluetooth.a2dp@1.0::IBluetoothAudioOffload

27f22d2e873e6201f9620cf4d8e2facb25bd0dd30a2b911e441b4600d560fa62 android.hardware.bluetooth.a2dp@1.0::types