Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 702909f1 authored by David Drysdale's avatar David Drysdale Committed by Automerger Merge Worker
Browse files

Merge "Fix attestation error checks" am: 82f86a1d am: 18283b6c am: 286d2f7e am: e13d20b7 

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2648423



Change-Id: I4267e1f42d843b690fc948cedc8efa3377448cb7
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 0b219c10 e13d20b7

security/keymint/aidl/vts/functional/KeyMintAidlTestBase.cpp

+10 −14
Original line number Original line Diff line number Diff line
@@ -2214,31 +2214,27 @@ void p256_pub_key(const vector<uint8_t>& coseKeyData, EVP_PKEY_Ptr* signingKey) 




// Check the error code from an attempt to perform device ID attestation with an invalid value.

// Check the error code from an attempt to perform device ID attestation with an invalid value.

void device_id_attestation_check_acceptable_error(Tag tag, const ErrorCode& result) {

void device_id_attestation_check_acceptable_error(Tag tag, const ErrorCode& result) {

    // Standard/default error code for ID mismatch.

    if (result == ErrorCode::CANNOT_ATTEST_IDS) {

    if (result == ErrorCode::CANNOT_ATTEST_IDS) {

        return;

        // Standard/default error code for ID mismatch.

    }

    } else if (result == ErrorCode::INVALID_TAG) {



        // Depending on the situation, other error codes may be acceptable.  First, allow older

        // Depending on the situation, other error codes may be acceptable.  First, allow older

        // implementations to use INVALID_TAG.

        // implementations to use INVALID_TAG.

    if (result == ErrorCode::INVALID_TAG) {

        ASSERT_FALSE(get_vsr_api_level() > __ANDROID_API_T__)

        ASSERT_FALSE(get_vsr_api_level() > __ANDROID_API_T__)

                << "It is a specification violation for INVALID_TAG to be returned due to ID "

                << "It is a specification violation for INVALID_TAG to be returned due to ID "

                << "mismatch in a Device ID Attestation call. INVALID_TAG is only intended to "

                << "mismatch in a Device ID Attestation call. INVALID_TAG is only intended to "

                << "be used for a case where updateAad() is called after update(). As of "

                << "be used for a case where updateAad() is called after update(). As of "

                << "VSR-14, this is now enforced as an error.";

                << "VSR-14, this is now enforced as an error.";

    }

    } else if (result == ErrorCode::ATTESTATION_IDS_NOT_PROVISIONED) {



        // If the device is not a phone, it will not have IMEI/MEID values available.  Allow

        // If the device is not a phone, it will not have IMEI/MEID values available.  Allow

        // ATTESTATION_IDS_NOT_PROVISIONED in this case.

        // ATTESTATION_IDS_NOT_PROVISIONED in this case.

    if (result == ErrorCode::ATTESTATION_IDS_NOT_PROVISIONED) {

        ASSERT_TRUE((tag == TAG_ATTESTATION_ID_IMEI || tag == TAG_ATTESTATION_ID_MEID ||

        ASSERT_TRUE((tag == TAG_ATTESTATION_ID_IMEI || tag == TAG_ATTESTATION_ID_MEID ||

                     tag == TAG_ATTESTATION_ID_SECOND_IMEI))

                     tag == TAG_ATTESTATION_ID_SECOND_IMEI))

                << "incorrect error code on attestation ID mismatch";

                << "incorrect error code on attestation ID mismatch";

    }

    } else {

        ADD_FAILURE() << "Error code " << result

        ADD_FAILURE() << "Error code " << result

                      << " returned on attestation ID mismatch, should be CANNOT_ATTEST_IDS";

                      << " returned on attestation ID mismatch, should be CANNOT_ATTEST_IDS";

    }

    }

}





// Check whether the given named feature is available.

// Check whether the given named feature is available.

bool check_feature(const std::string& name) {

bool check_feature(const std::string& name) {