Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ca90ed3 authored by Tomasz Wasilczyk's avatar Tomasz Wasilczyk
Browse files

Fix getProgramList comment about possible result. 

Also change default implementation results for not implemented calls
to be less harsh.

Test: instrumentation
Bug: b/36863239
Change-Id: I7f9adea8aa5b84aec81be13f5614ba16c8b74b75
parent 42fb6d97

broadcastradio/1.1/ITuner.hal

+1 −0
Original line number Diff line number Diff line
@@ -65,6 +65,7 @@ interface ITuner extends @1.0::ITuner { 
     *               Client application MUST verify vendor/product name

     *               before setting this parameter to anything else.

     * @return result OK if the list was successfully retrieved.

     *                INVALID_ARGUMENTS if invalid arguments are passed

     *                NOT_READY if the scan is in progress.

     *                NOT_STARTED if the scan has not been started, client may

     *                call startBackgroundScan to fix this.

broadcastradio/1.1/default/Tuner.cpp

+4 −4
Original line number Diff line number Diff line
@@ -201,25 +201,25 @@ exit: 
}



Return<ProgramListResult> Tuner::startBackgroundScan() {

    return ProgramListResult::NOT_INITIALIZED;

    return ProgramListResult::UNAVAILABLE;

}



Return<void> Tuner::getProgramList(const hidl_string& filter __unused, getProgramList_cb _hidl_cb) {

    hidl_vec<ProgramInfo> pList;

    // TODO(b/34054813): do the actual implementation.

    _hidl_cb(ProgramListResult::NOT_INITIALIZED, pList);

    _hidl_cb(ProgramListResult::NOT_STARTED, pList);

    return Void();

}



Return<void> Tuner::isAnalogForced(isAnalogForced_cb _hidl_cb) {

    // TODO(b/34348946): do the actual implementation.

    _hidl_cb(Result::NOT_INITIALIZED, false);

    _hidl_cb(Result::INVALID_STATE, false);

    return Void();

}



Return<Result> Tuner::setAnalogForced(bool isForced __unused) {

    // TODO(b/34348946): do the actual implementation.

    return Result::NOT_INITIALIZED;

    return Result::INVALID_STATE;

}



} // namespace implementation