Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c9c6e62 authored by Kevin Rocard's avatar Kevin Rocard
Browse files

Allow getCapturePosition to return 0 frames for unprepared streams 



For device supporting getCapturePosition,
VTS only allowed unprepared stream to return INVALID_STATE.
Now also allow for the stream to return 0 frames similarly to the other
non started states.

Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
Bug: 110367728
Cherry-piked from: d01dc3edac9e92981e7ae419d0e7622f753acf94
Change-Id: Ibdf8df8cb8809e98c40a50035371df6893fe4da4
Signed-off-by: default avatarKevin Rocard <krocard@google.com>
parent 7dab610c

audio/core/4.0/vts/functional/AudioPrimaryHidlHalTest.cpp

+9 −4
Original line number Diff line number Diff line
@@ -106,7 +106,10 @@ using namespace ::android::hardware::audio::common::test::utility; 
static auto okOrNotSupported = {Result::OK, Result::NOT_SUPPORTED};

static auto okOrNotSupportedOrInvalidArgs = {Result::OK, Result::NOT_SUPPORTED,

                                             Result::INVALID_ARGUMENTS};

static auto okOrInvalidStateOrNotSupported = {Result::OK, Result::INVALID_STATE,

                                              Result::NOT_SUPPORTED};

static auto invalidArgsOrNotSupported = {Result::INVALID_ARGUMENTS, Result::NOT_SUPPORTED};

static auto invalidStateOrNotSupported = {Result::INVALID_STATE, Result::NOT_SUPPORTED};



class AudioHidlTestEnvironment : public ::Environment {

   public:
@@ -949,8 +952,6 @@ TEST_IO_STREAM(RemoveNonExistingEffect, "Removing a non existing effect should f 
TEST_IO_STREAM(standby, "Make sure the stream can be put in stanby",

               ASSERT_OK(stream->standby()))  // can not fail



static constexpr auto invalidStateOrNotSupported = {Result::INVALID_STATE, Result::NOT_SUPPORTED};



TEST_IO_STREAM(startNoMmap, "Starting a mmaped stream before mapping it should fail",

               ASSERT_RESULT(invalidStateOrNotSupported, stream->start()))
@@ -1070,11 +1071,15 @@ TEST_P(InputStreamTest, GetInputFramesLost) { 
TEST_P(InputStreamTest, getCapturePosition) {

    doc::test(

        "The capture position of a non prepared stream should not be "

        "retrievable");

        "retrievable or 0");

    uint64_t frames;

    uint64_t time;

    ASSERT_OK(stream->getCapturePosition(returnIn(res, frames, time)));

    ASSERT_RESULT(invalidStateOrNotSupported, res);

    ASSERT_RESULT(okOrInvalidStateOrNotSupported, res);

    if (res == Result::OK) {

        ASSERT_EQ(0U, frames);

        ASSERT_LE(0U, time);

    }

}



TEST_P(InputStreamTest, updateSinkMetadata) {