Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c0284fb authored by Weilin Xu's avatar Weilin Xu
Browse files

Remove TODO in get/set parameter methods in bcradio 

Methods to set and get vendor parameters in broadcast radio HAL
can be not implemented simply as key-value map since vendors could
implement flexibly based on their requirements. Therefore, it is
better not to provide implementation of set/get parameters methods
in the default HAL.

Bug: 243683842
Flag: EXEMPT bugfix
Test: atest VtsHalBroadcastradioAidlTargetTest
Change-Id: Ibec9ef7cceb95907b96e686d7af0d6d3b3b5a23e
parent cfff9201

broadcastradio/aidl/default/BroadcastRadio.cpp

+0 −2
Original line number Diff line number Diff line
@@ -790,14 +790,12 @@ ScopedAStatus BroadcastRadio::setConfigFlag(ConfigFlag flag, bool value) { 
ScopedAStatus BroadcastRadio::setParameters(

        [[maybe_unused]] const vector<VendorKeyValue>& parameters,

        vector<VendorKeyValue>* returnParameters) {

    // TODO(b/243682330) Support vendor parameter functionality

    *returnParameters = {};

    return ScopedAStatus::ok();

}



ScopedAStatus BroadcastRadio::getParameters([[maybe_unused]] const vector<string>& keys,

                                            vector<VendorKeyValue>* returnParameters) {

    // TODO(b/243682330) Support vendor parameter functionality

    *returnParameters = {};

    return ScopedAStatus::ok();

}