Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b9bae82 authored by Steven Moreland's avatar Steven Moreland
Browse files

Removed overloaded functions from IFoo.hal. 

Bug: 31758541
Test: hidl_test
Change-Id: Ic92cf9996357a8aa9b3785540784c686887032e0
parent 7eb1f891

tests/bar/1.0/default/Bar.cpp

+0 −4
Original line number Diff line number Diff line
@@ -21,10 +21,6 @@ Return<void> Bar::doThis(float param) { 
    return mFoo->doThis(param);

}



Return<void> Bar::doThis(uint32_t param) {

    return mFoo->doThis(param);

}



Return<int32_t> Bar::doThatAndReturnSomething(

        int64_t param) {

    return mFoo->doThatAndReturnSomething(param);

tests/bar/1.0/default/Bar.h

+0 −1
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ struct Bar : public IBar { 


    // Methods from ::android::hardware::tests::foo::V1_0::IFoo follow.

    virtual Return<void> doThis(float param)  override;

    virtual Return<void> doThis(uint32_t param)  override;

    virtual Return<int32_t> doThatAndReturnSomething(int64_t param)  override;

    virtual Return<double> doQuiteABit(int32_t a, int64_t b, float c, double d)  override;

    virtual Return<void> doSomethingElse(const hidl_array<int32_t, 15 /* 15 */>& param, doSomethingElse_cb _hidl_cb)  override;

tests/foo/1.0/IFoo.hal

+0 −1
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ interface IFoo { 
    };



    doThis(float param);

    doThis(uint32_t param);

    doThatAndReturnSomething(int64_t param) generates (int32_t result);

    doQuiteABit(int32_t a, int64_t b, float c, double d) generates (double something);

    doSomethingElse(int32_t[15] param) generates (int32_t[32] something);

tests/foo/1.0/default/Android.bp

+0 −2
Original line number Diff line number Diff line
@@ -6,8 +6,6 @@ cc_library_shared { 
    srcs: [

        "Foo.cpp",

        "FooCallback.cpp",

        "MyTypes.cpp",

        "TheirTypes.cpp",

    ],



    shared_libs: [

tests/foo/1.0/default/Foo.cpp

+0 −5
Original line number Diff line number Diff line
@@ -21,11 +21,6 @@ Return<void> Foo::doThis(float param) { 
    return Void();

}



Return<void> Foo::doThis(uint32_t param) {

    ALOGI("SERVER(Foo) doThis (int) (%d)", param);

    return Void();

}



Return<int32_t> Foo::doThatAndReturnSomething(

        int64_t param) {

    LOG(INFO) << "SERVER(Foo) doThatAndReturnSomething(" << param << ")";