Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6adbf0c1 authored by Liu, Kai1's avatar Liu, Kai1 Committed by Android Build Cherrypicker Worker
Browse files

Assert the errors size to 1 for case SetDisplayBrightness 



null pointer dereference crash will be triggered if vector errors
is emptry when accessing errors[0].errorCode, so change EXPECT_EQ
to ASSERT_EQ to avoid this issue.

Test: run vts -m VtsHalGraphicsComposer3_TargetTest

Signed-off-by: default avatarLiu, Kai1 <kai1.liu@intel.com>
(cherry picked from https://android-review.googlesource.com/q/commit:aec33e9a41e4bccfd1834e1ab03f785eea4f0b52)
Merged-In: I3b30d491ef886b98e462447e6de78828e7822fca
Change-Id: I3b30d491ef886b98e462447e6de78828e7822fca
parent 0309dddb

graphics/composer/aidl/vts/VtsHalGraphicsComposer3_TargetTest.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1839,7 +1839,7 @@ TEST_P(GraphicsComposerAidlCommandTest, SetDisplayBrightness) { 
        writer.setDisplayBrightness(getPrimaryDisplayId(), /*brightness*/ 0.5f, -1.f);

        execute();

        const auto errors = mReader.takeErrors();

        EXPECT_EQ(1, errors.size());

        ASSERT_EQ(1, errors.size());

        EXPECT_EQ(IComposerClient::EX_UNSUPPORTED, errors[0].errorCode);

        GTEST_SUCCEED() << "SetDisplayBrightness is not supported";

        return;