Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6aae4501 authored by Nathan Harold's avatar Nathan Harold Committed by Steven Moreland
Browse files

Fix LTE Timing Advance Doc String 

The LTE TA Doc string has been fixed to reflect
the actual reported value of the field. The spec
reference was previously incorrect, which would
have indicated a range of 0-63 as the incremental
timing advance; however the field actually reports
the absolute timing advance, which has a much
larger range of 0-1282. In addition, this CL
updates the comment to remove a link to a defunct
website and explicitly states the range extracted
from the updated spec reference. This does not
impact the current behavior of the API as the the
previously incorrect docstring was nonsensical.

Bug: 66751464
Test: compilation (doc only change)
Change-Id: I2fc90c08ed6dd14548b10c638bf805b37d5c34e8
parent b6a8851f

current.txt

+1 −0
Original line number Diff line number Diff line
@@ -255,4 +255,5 @@ cf72ff5a52bfa4d08e9e1000cf3ab5952a2d280c7f13cdad5ab7905c08050766 android.hardwar 
fb92e2b40f8e9d494e8fd3b4ac18499a3216342e7cff160714c3bbf3660b6e79 android.hardware.gnss@1.0::IGnssConfiguration

251594ea9b27447bfa005ebd806e58fb0ae4aad84a69938129c9800ec0c64eda android.hardware.gnss@1.0::IGnssMeasurementCallback

4e7169919d24fbe5573e5bcd683d0bd7abf553a4e6c34c41f9dfc1e12050db07 android.hardware.gnss@1.0::IGnssNavigationMessageCallback

0e6e80ddd5c312726e20b003af438325a2d7c305a60a8c8d8e229df2306d50df android.hardware.radio@1.0::types

b280c4704dfcc548a9bf127b59b7c3578f460c50cce70a06b66fe0df8b27cff0 android.hardware.wifi@1.0::types

radio/1.0/types.hal

+3 −4
Original line number Diff line number Diff line
@@ -1292,10 +1292,9 @@ struct LteSignalStrength { 
                                          // from cell to device.

                                          // Approximate distance is calculated using

                                          // 300m/us * timingAdvance.

                                          // Range: 0 to 0x7FFFFFFE

                                          // INT_MAX : 0x7FFFFFFF denotes invalid value.

                                          // Reference: 3GPP 36.321 section 6.1.3.5

                                          // also: http://www.cellular-planningoptimization.com/2010/02/timing-advance-with-calculation.html

                                          // Range: 0 to 1282 inclusive.

                                          // INT_MAX : 0x7FFFFFFF denotes unknown value.

                                          // Reference: 3GPP 36.213 section 4.2.3

};



struct TdScdmaSignalStrength {