Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6755d76d authored by Shunkai Yao's avatar Shunkai Yao
Browse files

Use final specifier for all effects implementation classes. 

Avoid inherit from effect implementation class, all
implmentations should inherit EffectImpl directly.

Bug: 255361653
Test: atest VtsHalAudioEffectTargetTest
atest VtsHalAudioEffectFactoryTargetTest
atest VtsHalEqualizerTargetTest

Change-Id: I3c3bd990423be21f2c79f0e797d71b2d7f850dca
parent 6acc2e59

audio/aidl/default/bassboost/BassBoostSw.h

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


namespace aidl::android::hardware::audio::effect {



class BassBoostSwContext : public EffectContext {

class BassBoostSwContext final : public EffectContext {

  public:

    BassBoostSwContext(int statusDepth, const Parameter::Common& common)

        : EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class BassBoostSwContext : public EffectContext { 
    // TODO: add specific context here

};



class BassBoostSw : public EffectImpl {

class BassBoostSw final : public EffectImpl {

  public:

    BassBoostSw() { LOG(DEBUG) << __func__; }

    ~BassBoostSw() {

audio/aidl/default/dynamicProcessing/DynamicsProcessingSw.h

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


namespace aidl::android::hardware::audio::effect {



class DynamicsProcessingSwContext : public EffectContext {

class DynamicsProcessingSwContext final : public EffectContext {

  public:

    DynamicsProcessingSwContext(int statusDepth, const Parameter::Common& common)

        : EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class DynamicsProcessingSwContext : public EffectContext { 
    // TODO: add specific context here

};



class DynamicsProcessingSw : public EffectImpl {

class DynamicsProcessingSw final : public EffectImpl {

  public:

    DynamicsProcessingSw() { LOG(DEBUG) << __func__; }

    ~DynamicsProcessingSw() {

audio/aidl/default/hapticGenerator/HapticGeneratorSw.h

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


namespace aidl::android::hardware::audio::effect {



class HapticGeneratorSwContext : public EffectContext {

class HapticGeneratorSwContext final : public EffectContext {

  public:

    HapticGeneratorSwContext(int statusDepth, const Parameter::Common& common)

        : EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class HapticGeneratorSwContext : public EffectContext { 
    // TODO: add specific context here

};



class HapticGeneratorSw : public EffectImpl {

class HapticGeneratorSw final : public EffectImpl {

  public:

    HapticGeneratorSw() { LOG(DEBUG) << __func__; }

    ~HapticGeneratorSw() {

audio/aidl/default/loudnessEnhancer/LoudnessEnhancerSw.h

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


namespace aidl::android::hardware::audio::effect {



class LoudnessEnhancerSwContext : public EffectContext {

class LoudnessEnhancerSwContext final : public EffectContext {

  public:

    LoudnessEnhancerSwContext(int statusDepth, const Parameter::Common& common)

        : EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class LoudnessEnhancerSwContext : public EffectContext { 
    // TODO: add specific context here

};



class LoudnessEnhancerSw : public EffectImpl {

class LoudnessEnhancerSw final : public EffectImpl {

  public:

    LoudnessEnhancerSw() { LOG(DEBUG) << __func__; }

    ~LoudnessEnhancerSw() {

audio/aidl/default/reverb/ReverbSw.h

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


namespace aidl::android::hardware::audio::effect {



class ReverbSwContext : public EffectContext {

class ReverbSwContext final : public EffectContext {

  public:

    ReverbSwContext(int statusDepth, const Parameter::Common& common)

        : EffectContext(statusDepth, common) {
@@ -35,7 +35,7 @@ class ReverbSwContext : public EffectContext { 
    // TODO: add specific context here

};



class ReverbSw : public EffectImpl {

class ReverbSw final : public EffectImpl {

  public:

    ReverbSw() { LOG(DEBUG) << __func__; }

    ~ReverbSw() {