Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5babeec8 authored by KH Shi's avatar KH Shi
Browse files

Follow-up commit of aosp/2329897 

This commit resolves comments addressed in aosp/2329897.
- Remove EX_UNSUPPORTED_OPERATION return from setDataWarningAndLimit()
- Update some comments
- Change some errors into assertions
- Correct the sequence of the arguments in EXPECT_EQ(), expected
  argument goes before the actual argument
- Print error or error message if API call fails

Bug: b/205762647
Test: atest VtsHalTetheroffloadTargetTest
Change-Id: Ied83dac5c33e06f6ad4ced18fbee785047b24c38
(cherry picked from commit 562cbfee)
Merged-In: Ied83dac5c33e06f6ad4ced18fbee785047b24c38
parent 3e176547

tetheroffload/aidl/android/hardware/tetheroffload/IOffload.aidl

+2 −4
Original line number Diff line number Diff line
@@ -32,8 +32,7 @@ interface IOffload { 
    /**

     * Indicates intent to start offload for tethering in immediate future.

     *

     * This API must be called exactly once the first time that Tethering is requested by

     * the user.

     * This API must be called exactly once when Tethering is requested by the user.

     *

     * If this API is called multiple times without first calling stopOffload, then the subsequent

     * calls must fail without changing the state of the server.
@@ -168,7 +167,6 @@ interface IOffload { 
     *           or negative number of bytes).

     *         - EX_ILLEGAL_STATE if this method is called before initOffload(), or if this method

     *           is called after stopOffload().

     *         - EX_UNSUPPORTED_OPERATION if it is not supported.

     *         - EX_SERVICE_SPECIFIC with the error message set to a human-readable reason for the

     *           error.

     */
@@ -269,7 +267,7 @@ interface IOffload { 
     * This API may only be called after initOffload and before stopOffload.

     *

     * @param iface  Downstream interface

     * @param prefix Downstream prefix depicting address that must no longer be offloaded

     * @param prefix Downstream prefix depicting prefix that must no longer be offloaded

     *               For e.g. 192.168.1.0/24 or 2001:4860:684::/64)

     *

     * @throws:

tetheroffload/aidl/android/hardware/tetheroffload/OffloadCallbackEvent.aidl

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ enum OffloadCallbackEvent { 
     */

    OFFLOAD_STOPPED_LIMIT_REACHED = 5,

    /**

     * This event is fired when the quota, applied in setDataWarning, has expired. It is

     * This event is fired when the quota, applied in setDataWarningAndLimit, has expired. It is

     * recommended that the client query for statistics immediately after receiving this event.

     * Any offloaded traffic will continue to be offloaded until offload is stopped or

     * OFFLOAD_STOPPED_LIMIT_REACHED is sent.

tetheroffload/aidl/vts/functional/VtsHalTetheroffloadTargetTest.cpp

+81 −69

File changed.

Preview size limit exceeded, changes collapsed.