Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5659221d authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

audio VTS: Exclude '1' from 'invalid' buffer size list 

This affects AudioStream{In|Out}.OpenInvalidBufferSize test.
Leave only values that are obviously invalid.

Bug: 205884982
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I148b823761175959a1cf658599c038378ac4b116
parent 4c4ebb32

audio/aidl/vts/VtsHalAudioCoreModuleTargetTest.cpp

+1 −3
Original line number Diff line number Diff line
@@ -1899,9 +1899,7 @@ class AudioStream : public AudioCoreModule { 
        }

        WithStream<Stream> stream(portConfig.value());

        ASSERT_NO_FATAL_FAILURE(stream.SetUpPortConfig(module.get()));

        // The buffer size of 1 frame should be impractically small, and thus

        // less than any minimum buffer size suggested by any HAL.

        for (long bufferSize : std::array<long, 4>{-1, 0, 1, std::numeric_limits<long>::max()}) {

        for (long bufferSize : std::array<long, 3>{-1, 0, std::numeric_limits<long>::max()}) {

            EXPECT_STATUS(EX_ILLEGAL_ARGUMENT, stream.SetUpNoChecks(module.get(), bufferSize))

                    << "for the buffer size " << bufferSize;

            EXPECT_EQ(nullptr, stream.get());