Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52416e06 authored by ramindani's avatar ramindani
Browse files

[Composer3] Update notifyExpectedPresent parameter names 

Update the timeoutNs description to specify what 0 and not absent value
expected behavior is
BUG: 294102485
Test: VTS

Change-Id: I3954c8f1efad8190ed6d608e2968fe1dc15c2f11
parent 51548b2a

graphics/composer/aidl/aidl_api/android.hardware.graphics.composer3/current/android/hardware/graphics/composer3/VrrConfig.aidl

+2 −2
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ parcelable VrrConfig { 
    int averageRefreshPeriodNs;

  }

  parcelable NotifyExpectedPresentConfig {

    int notifyExpectedPresentHeadsUpNs;

    int notifyExpectedPresentTimeoutNs;

    int headsUpNs;

    int timeoutNs;

  }

}

graphics/composer/aidl/android/hardware/graphics/composer3/IComposerClient.aidl

+3 −3
Original line number Diff line number Diff line
@@ -895,9 +895,9 @@ interface IComposerClient { 
     *

     * The framework will call this function based on the parameters specified in

     * DisplayConfiguration.VrrConfig:

     * - notifyExpectedPresentTimeoutNs specifies the idle time from the previous present command

     * where the framework must send the early hint for the next frame.

     * - notifyExpectedPresentHeadsUpNs specifies minimal time that framework must send

     * - notifyExpectedPresentConfig.timeoutNs specifies the idle time from the previous

     * present command where the framework must send the early hint for the next frame.

     * - notifyExpectedPresentConfig.headsUpNs specifies minimal time that framework must send

     * the early hint before the next frame.

     *

     * The framework can omit calling this API when the next present command matches

graphics/composer/aidl/android/hardware/graphics/composer3/VrrConfig.aidl

+4 −3
Original line number Diff line number Diff line
@@ -45,15 +45,16 @@ parcelable VrrConfig { 
         * The minimal time in nanoseconds that IComposerClient.notifyExpectedPresent needs to be

         * called ahead of an expectedPresentTime provided on a presentDisplay command.

         */

        int notifyExpectedPresentHeadsUpNs;

        int headsUpNs;



        /**

         * The time in nanoseconds that represents a timeout from the previous presentDisplay, which

         * after this point the display needs a call to IComposerClient.notifyExpectedPresent before

         * sending the next frame. If set to 0, there is no need to call

         * sending the next frame.

         * If set to 0, hint is sent for every frame.

         * IComposerClient.notifyExpectedPresent for timeout.

         */

        int notifyExpectedPresentTimeoutNs;

        int timeoutNs;

    }



    /**

graphics/composer/aidl/vts/VtsHalGraphicsComposer3_TargetTest.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1275,8 +1275,8 @@ TEST_P(GraphicsComposerAidlV3Test, GetDisplayConfigurations) { 
                if (vrrConfig.notifyExpectedPresentConfig) {

                    const auto& notifyExpectedPresentConfig =

                            *vrrConfig.notifyExpectedPresentConfig;

                    EXPECT_GT(0, notifyExpectedPresentConfig.notifyExpectedPresentHeadsUpNs);

                    EXPECT_GE(0, notifyExpectedPresentConfig.notifyExpectedPresentTimeoutNs);

                    EXPECT_GE(notifyExpectedPresentConfig.headsUpNs, 0);

                    EXPECT_GE(notifyExpectedPresentConfig.timeoutNs, 0);

                }

            }

        }