Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fe33ed2 authored by Henry Fang's avatar Henry Fang Committed by Amy
Browse files

Add comments for invalid IP/port and add Invalid filterID/avSyncId 

To allow client to identify and specify invalid value

bug: 148110220
Test: Manual
Change-Id: Ib5e88a13cdcca0b62f55fab992293ed17e0ed708
(cherry picked from commit 460b9610)
parent 116a7e2e

tv/tuner/1.0/types.hal

+27 −1
Original line number Diff line number Diff line
@@ -1922,7 +1922,7 @@ safe_union DemuxPid { 
};



@export

enum Constant : uint16_t {

enum Constant : uint32_t {

    /**

     * An invalid packet ID in transport stream according to ISO/IEC 13818-1.

     */
@@ -1931,6 +1931,14 @@ enum Constant : uint16_t { 
     * An invalid Stream ID.

     */

    INVALID_STREAM_ID = 0xFFFF,

    /**

     * An invalid Filter ID.

     */

    INVALID_FILTER_ID = 0xFFFFFFFF,

    /**

     * An invalid AV sync hardware ID.

     */

    INVALID_AV_SYNC_ID = 0xFFFFFFFF,

};



/**
@@ -2152,19 +2160,37 @@ struct DemuxFilterDownloadSettings { 
 */

struct DemuxIpAddress {

    safe_union SrcIpAddress {

        /**

         * 0.0.0.0 is invalid. should be ignored.

         */

        uint8_t[4] v4;



        /**

         * 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0 is invalid. should be ignored.

         */

        uint8_t[16] v6;

    } srcIpAddress;



    safe_union DstIpAddress {

        /**

         * 0.0.0.0 is invalid. should be ignored.

         */

        uint8_t[4] v4;



        /**

         * 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0 is invalid. should be ignored.

         */

        uint8_t[16] v6;

    } dstIpAddress;



    /**

     * 0 is invalid. should be ignored.

     */

    uint16_t srcPort;



    /**

     * 0 is invalid. should be ignored.

     */

    uint16_t dstPort;

};