Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48bc8ffb authored by Les Lee's avatar Les Lee Committed by Android (Google) Code Review
Browse files

Merge "wifi: fix a use of an uninitialized value" into sc-dev

parents 4fce8e07 2c0a47db
Loading
Loading
Loading
Loading
+4 −5
Original line number Diff line number Diff line
@@ -1036,7 +1036,6 @@ WifiStatus WifiChip::removeApIfaceInternal(const std::string& ifname) {

WifiStatus WifiChip::removeIfaceInstanceFromBridgedApIfaceInternal(
    const std::string& ifname, const std::string& ifInstanceName) {
    legacy_hal::wifi_error legacy_status;
    const auto iface = findUsingName(ap_ifaces_, ifname);
    if (!iface.get() || ifInstanceName.empty()) {
        return createWifiStatus(WifiStatusCode::ERROR_INVALID_ARGS);
@@ -1048,13 +1047,13 @@ WifiStatus WifiChip::removeIfaceInstanceFromBridgedApIfaceInternal(
                if (iface == ifInstanceName) {
                    if (!iface_util_.lock()->removeIfaceFromBridge(it.first,
                                                                   iface)) {
                        LOG(ERROR) << "Failed to remove interface: " << iface
                                   << " from " << ifname << ", error: "
                                   << legacyErrorToString(legacy_status);
                        LOG(ERROR)
                            << "Failed to remove interface: " << ifInstanceName
                            << " from " << ifname;
                        return createWifiStatus(
                            WifiStatusCode::ERROR_NOT_AVAILABLE);
                    }
                    legacy_status =
                    legacy_hal::wifi_error legacy_status =
                        legacy_hal_.lock()->deleteVirtualInterface(iface);
                    if (legacy_status != legacy_hal::WIFI_SUCCESS) {
                        LOG(ERROR) << "Failed to del interface: " << iface