Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41b4c272 authored by Gabriel Biren's avatar Gabriel Biren
Browse files

Improvements for the Wifi Chip VTS test. 

Changes include:
 - Add call to stopLoggingToDebugRingBuffer
   in the debug ring buffer test
 - Remove explicit getName tests for STA and
   NAN ifaces, since these methods are already
   tested implicity in the Wifi Chip test

Note that the two getName tests were added this
year, so they should not be needed.

Bug: 386810503
Test: atest VtsHalWifiChipTargetTest \
            VtsHalWifiNanIfaceTargetTest \
            VtsHalWifiStaIfaceTargetTest
Change-Id: I0b89374d3ecc139e9b28f184c3f6dad76c8c76c0
parent e4da126f

wifi/aidl/vts/functional/wifi_chip_aidl_test.cpp

+3 −0
Original line number Diff line number Diff line
@@ -526,6 +526,9 @@ TEST_P(WifiChipAidlTest, StartLoggingToDebugRingBuffer) { 
    status = wifi_chip_->startLoggingToDebugRingBuffer(

            ring_name, WifiDebugRingBufferVerboseLevel::VERBOSE, 5, 1024);

    EXPECT_TRUE(status.isOk() || checkStatusCode(&status, WifiStatusCode::ERROR_NOT_SUPPORTED));



    status = wifi_chip_->stopLoggingToDebugRingBuffer();

    EXPECT_TRUE(status.isOk() || checkStatusCode(&status, WifiStatusCode::ERROR_NOT_SUPPORTED));

}



/*

wifi/aidl/vts/functional/wifi_nan_iface_aidl_test.cpp

+0 −8
Original line number Diff line number Diff line
@@ -519,14 +519,6 @@ class WifiNanIfaceAidlTest : public testing::TestWithParam<std::string> { 
    std::condition_variable cv_;

};



/*

 * GetName

 */

TEST_P(WifiNanIfaceAidlTest, GetName) {

    std::string ifaceName;

    EXPECT_TRUE(wifi_nan_iface_->getName(&ifaceName).isOk());

}



/*

 * FailOnIfaceInvalid

 * Ensure that API calls to an interface fail with code ERROR_WIFI_IFACE_INVALID

wifi/aidl/vts/functional/wifi_sta_iface_aidl_test.cpp

+0 −8
Original line number Diff line number Diff line
@@ -530,14 +530,6 @@ TEST_P(WifiStaIfaceAidlTest, TwtSessionResume) { 
    EXPECT_TRUE(wifi_sta_iface_->twtSessionResume(1, 10).isOk());

}



/*

 * GetName

 */

TEST_P(WifiStaIfaceAidlTest, GetName) {

    std::string ifaceName;

    EXPECT_TRUE(wifi_sta_iface_->getName(&ifaceName).isOk());

}



/*

 * SetDtimMultiplier

 */