Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e9720b8 authored by Michael Butler's avatar Michael Butler
Browse files

Remove NN canonical IDevice::isUpdatable -- hal 

This CL alters the AIDL utility "getDevices" to return whether or not a
service is updatable. This CL additional removes IDevice::isUpdatable
because it is now redundant with the changes to "getDevices".

Bug: 170696350
Test: mma
Test: NeuralNetworksTest_static
Change-Id: I86228763937c0dd2ee5b1d9d547c367cd7504ed4
parent 91ce32ad

neuralnetworks/1.0/utils/include/nnapi/hal/1.0/Device.h

+0 −1
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ class Device final : public nn::IDevice { 
    const std::string& getVersionString() const override;

    nn::Version getFeatureLevel() const override;

    nn::DeviceType getType() const override;

    bool isUpdatable() const override;

    const std::vector<nn::Extension>& getSupportedExtensions() const override;

    const nn::Capabilities& getCapabilities() const override;

    std::pair<uint32_t, uint32_t> getNumberOfCacheFilesNeeded() const override;

neuralnetworks/1.0/utils/src/Device.cpp

+0 −4
Original line number Diff line number Diff line
@@ -106,10 +106,6 @@ nn::DeviceType Device::getType() const { 
    return nn::DeviceType::OTHER;

}



bool Device::isUpdatable() const {

    return false;

}



const std::vector<nn::Extension>& Device::getSupportedExtensions() const {

    return kExtensions;

}

neuralnetworks/1.1/utils/include/nnapi/hal/1.1/Device.h

+0 −1
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ class Device final : public nn::IDevice { 
    const std::string& getVersionString() const override;

    nn::Version getFeatureLevel() const override;

    nn::DeviceType getType() const override;

    bool isUpdatable() const override;

    const std::vector<nn::Extension>& getSupportedExtensions() const override;

    const nn::Capabilities& getCapabilities() const override;

    std::pair<uint32_t, uint32_t> getNumberOfCacheFilesNeeded() const override;

neuralnetworks/1.1/utils/src/Device.cpp

+0 −4
Original line number Diff line number Diff line
@@ -106,10 +106,6 @@ nn::DeviceType Device::getType() const { 
    return nn::DeviceType::UNKNOWN;

}



bool Device::isUpdatable() const {

    return false;

}



const std::vector<nn::Extension>& Device::getSupportedExtensions() const {

    return kExtensions;

}

neuralnetworks/1.2/utils/include/nnapi/hal/1.2/Device.h

+0 −1
Original line number Diff line number Diff line
@@ -71,7 +71,6 @@ class Device final : public nn::IDevice { 
    const std::string& getVersionString() const override;

    nn::Version getFeatureLevel() const override;

    nn::DeviceType getType() const override;

    bool isUpdatable() const override;

    const std::vector<nn::Extension>& getSupportedExtensions() const override;

    const nn::Capabilities& getCapabilities() const override;

    std::pair<uint32_t, uint32_t> getNumberOfCacheFilesNeeded() const override;