Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a32a2b0 authored by Valerie Hau's avatar Valerie Hau
Browse files

Fixing file descriptor close bug and display refresh bug

Test: ./VtsHalGraphicsComposerV2_2TargetTest
Change-Id: Ib3de65ab33496bb89c708d0b98966b0084f0bd10
parent 8795bddd
Loading
Loading
Loading
Loading
+10 −3
Original line number Diff line number Diff line
@@ -289,8 +289,6 @@ TEST_F(GraphicsComposerReadbackTest, SingleSolidColorLayer) {
    int32_t fenceHandle;
    mComposerClient->getReadbackBufferFence(mPrimaryDisplay, &fenceHandle);

    base::unique_fd fence(fenceHandle);

    // lock buffer
    // Create Rect accessRegion to specify reading the entire buffer
    IMapper::Rect accessRegion;
@@ -299,8 +297,17 @@ TEST_F(GraphicsComposerReadbackTest, SingleSolidColorLayer) {
    accessRegion.width = info.width;
    accessRegion.height = info.height;

    void* bufData = mGralloc->lock(buffer, info.usage, accessRegion, fence);
    void* bufData = mGralloc->lock(buffer, info.usage, accessRegion, fenceHandle);
    checkReadbackBuffer(info, stride, bufData, expectedColors);
    int unlockFence = mGralloc->unlock(buffer);

    if (unlockFence != -1) {
        close(unlockFence);
    }

    mWriter->validateDisplay();
    mWriter->presentDisplay();
    execute();
}

}  // anonymous namespace