Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38585c25 authored by Pawin Vongmasa's avatar Pawin Vongmasa
Browse files

Remove the return Status from IGraphicBufferSource's functions. 

Now, only the transport-level status is needed, so
::android::hardware::Status is sufficient.

Also simplify IOmxNode::sendCommand().

Test: Compiles

Bug: 31399200
Change-Id: Ia4cfc16681d19eb96f89d8db715fcc14516cb41a
parent cba23c66

media/omx/1.0/IGraphicBufferSource.hal

+9 −18
Original line number Diff line number Diff line
@@ -29,32 +29,23 @@ import IOmxNode; 
 */

interface IGraphicBufferSource {



    configure(IOmxNode omxNode, Dataspace dataspace)

        generates (Status status);

    configure(IOmxNode omxNode, Dataspace dataspace);



    setSuspend(bool suspend)

        generates (Status status);

    setSuspend(bool suspend);



    setRepeatPreviousFrameDelayUs(int64_t repeatAfterUs)

        generates (Status status);

    setRepeatPreviousFrameDelayUs(int64_t repeatAfterUs);



    setMaxFps(float maxFps)

        generates (Status status);

    setMaxFps(float maxFps);



    setTimeLapseConfig(int64_t timePerFrameUs, int64_t timePerCaptureUs)

        generates (Status status);

    setTimeLapseConfig(int64_t timePerFrameUs, int64_t timePerCaptureUs);



    setStartTimeUs(int64_t startTimeUs)

        generates (Status status);

    setStartTimeUs(int64_t startTimeUs);



    setColorAspects(ColorAspects aspects)

        generates (Status status);

    setColorAspects(ColorAspects aspects);



    setTimeOffsetUs(int64_t timeOffsetUs)

        generates (Status status);

    setTimeOffsetUs(int64_t timeOffsetUs);



    signalEndOfInputStream()

        generates (Status status);

    signalEndOfInputStream();



};

media/omx/1.0/IOmxNode.hal

+2 −2
Original line number Diff line number Diff line
@@ -46,14 +46,14 @@ interface IOmxNode { 
     * Invoke a command on the node.

     *

     * @param[in] cmd indicates the type of the command.

     * @param[in] info holds information about the command.

     * @param[in] param is a parameter for the command.

     * @param[out] status will be the status of the call.

     *

     * @see OMX_SendCommand() in the OpenMax IL standard.

     */

    sendCommand(

            uint32_t cmd,

            Bytes info // TODO: describe structure better or point at standard

            int32_t param

        ) generates (

            Status status

        );