Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37e1a5dc authored by Emilian Peev's avatar Emilian Peev
Browse files

Camera: Include session parameters for 3.4 devices 

To avoid glitches and unexpected behavior, session parameters
should be included in the stream configuration before invoking
capture requests.

Bug: 70560715
Test: run vts --skip-all-system-status-check --skip-preconditions
--primary-abi-only --module VtsHalCameraProviderV2_4Target -l INFO

Change-Id: Id4ecd40533157f1a3299099a984ffab21654548a
parent e541981a

camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp

+7 −0
Original line number Diff line number Diff line
@@ -3833,6 +3833,13 @@ void CameraHidlTest::configurePreviewStream(const std::string &name, int32_t dev 
    ::android::hardware::camera::device::V3_4::StreamConfiguration config;

    config.v3_2 = {streams, StreamConfigurationMode::NORMAL_MODE};

    if (session3_4 != nullptr) {

        RequestTemplate reqTemplate = RequestTemplate::PREVIEW;

        ret = session3_4->constructDefaultRequestSettings(reqTemplate,

                                                       [&config](auto status, const auto& req) {

                                                           ASSERT_EQ(Status::OK, status);

                                                           config.sessionParams = req;

                                                       });

        ASSERT_TRUE(ret.isOk());

        ret = session3_4->configureStreams_3_4(config,

                [&] (Status s, device::V3_3::HalStreamConfiguration halConfig) {

                    ASSERT_EQ(Status::OK, s);