Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 374bec34 authored by Nathan Harold's avatar Nathan Harold
Browse files

Update UsageSetting Cache before comparison in VTS 

The final step of the RadioNewtorkTest#setUsageSetting
is to restore the original value to the modem in case it was
changed. After doing that, the locally cached value in the
VTS layer needs to be updated before comparing it with the
originally queried value to ensure that the modem was
restored to its initial state.

Bug: 211819471
Test: m VtsHalRadioTargetTest
Change-Id: Ibdd584d91b16bb779a0cefa2f45d2704cdcf7288
parent 2ed773b3

radio/aidl/vts/radio_network_test.cpp

+8 −3
Original line number Diff line number Diff line
@@ -264,11 +264,16 @@ TEST_P(RadioNetworkTest, setUsageSetting) { 
            [&](int serial) { return radio_network->setUsageSetting(serial, originalSetting); },

            {RadioError::NONE});



    // After resetting the value to its original value, update the local cache, which must

    // always succeed.

    invokeAndExpectResponse([&](int serial) { return radio_network->getUsageSetting(serial); },

                            {RadioError::NONE});



    // Check that indeed the updated setting was set. We do this after resetting to original

    // conditions to avoid early-exiting the test and leaving the device in a modified state.

    ASSERT_TRUE(expectedSetting == updatedSetting);

    EXPECT_EQ(expectedSetting, updatedSetting);

    // Check that indeed the original setting was reset.

    ASSERT_TRUE(originalSetting == radioRsp_network->usageSetting);

    EXPECT_EQ(originalSetting, radioRsp_network->usageSetting);

}



/*