Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 357e1dea authored by Yin-Chia Yeh's avatar Yin-Chia Yeh
Browse files

Camera: fix HAL1 removeCamera crash 

Test: partner testing
Bug: 173511749
Change-Id: Ifd5fc7c63e3835945194291d161b491bd5acb342
parent fb4367c3

camera/common/1.0/default/CameraModule.cpp

+20 −15
Original line number Diff line number Diff line
@@ -529,6 +529,9 @@ status_t CameraModule::filterOpenErrorCode(status_t err) { 
}



void CameraModule::removeCamera(int cameraId) {

    // Skip HAL1 devices which isn't cached in mCameraInfoMap and don't advertise

    // static_camera_characteristics

    if (getDeviceVersion(cameraId) >= CAMERA_DEVICE_API_VERSION_3_0) {

        std::unordered_set<std::string> physicalIds;

        camera_metadata_t *metadata = const_cast<camera_metadata_t*>(

                mCameraInfoMap.valueFor(cameraId).static_camera_characteristics);
@@ -547,6 +550,8 @@ void CameraModule::removeCamera(int cameraId) { 
            }

        }

        free_camera_metadata(metadata);

    }



    mCameraInfoMap.removeItem(cameraId);

    mDeviceVersionMap.removeItem(cameraId);

}