Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31aed67a authored by paulhu's avatar paulhu
Browse files

Expose detailed data call end reasons 

Currently, most of the fail causes for data connectivity are
exposed as ERROR_UNSPECIFIED. To know the precise fail
cause not just common exception, add more cause definitions
let exact fail reason can pass up to the apps from modem.

Bug: 113505704
Test: Build pass and data call can setup normally.
Change-Id: I1c8b910c272a027c811434d6d034b60ebfd64afa
parent 4ffb6e0b

radio/1.4/Android.bp

+4 −0
Original line number Diff line number Diff line
@@ -26,6 +26,8 @@ hidl_interface { 
        "CellConfigLte",

        "CellInfo",

        "CellInfoLte",

        "DataCallFailCause",

        "DataConnActiveStatus",

        "DataProfileInfo",

        "DataRegStateResult",

        "EmergencyNumber",
@@ -34,12 +36,14 @@ hidl_interface { 
        "FrequencyRange",

        "LteVopsInfo",

        "NetworkScanResult",

        "PdpProtocolType",

        "PhysicalChannelConfig",

        "RadioAccessFamily",

        "RadioCapability",

        "RadioFrequencyInfo",

        "RadioTechnology",

        "NrIndicators",

        "SetupDataCallResult",

    ],

    gen_java: true,

}

radio/1.4/IRadioIndication.hal

+15 −1
Original line number Diff line number Diff line
@@ -73,4 +73,18 @@ interface IRadioIndication extends @1.3::IRadioIndication { 
     */

    oneway currentPhysicalChannelConfigs_1_4(RadioIndicationType type,

            vec<PhysicalChannelConfig> configs);



    /**

     * Indicates data call contexts have changed.

     *

     * @param type Type of radio indication

     * @param dcList Array of SetupDataCallResult identical to that returned by

     *        IRadio.getDataCallList(). It is the complete list of current data contexts including

     *        new contexts that have been activated. A data call is only removed from this list

     *        when below conditions matched.

     *        1. The framework sends a IRadio.deactivateDataCall().

     *        2. The radio is powered off/on.

     *        3. Unsolicited disconnect from either modem or network side.

     */

    oneway dataCallListChanged_1_4(RadioIndicationType type, vec<SetupDataCallResult> dcList);

};

radio/1.4/IRadioResponse.hal

+37 −0
Original line number Diff line number Diff line
@@ -127,4 +127,41 @@ interface IRadioResponse extends @1.3::IRadioResponse { 
     *   RadioError:CANCELLED

     */

    oneway setPreferredNetworkTypeBitmapResponse(RadioResponseInfo info);



    /**

     * @param info Response info struct containing response type, serial no. and error

     * @param dcResponse List of DataCallResult as defined in types.hal

     *

     * Valid errors returned:

     *   RadioError:NONE

     *   RadioError:RADIO_NOT_AVAILABLE

     *   RadioError:INTERNAL_ERR

     *   RadioError:NO_MEMORY

     *   RadioError:NO_RESOURCES

     *   RadioError:CANCELLED

     *   RadioError:REQUEST_NOT_SUPPORTED

     *   RadioError:SIM_ABSENT

     */

    oneway getDataCallListResponse_1_4(RadioResponseInfo info, vec<SetupDataCallResult> dcResponse);



    /**

     * @param info Response info struct containing response type, serial no. and error

     * @param dcResponse SetupDataCallResult defined in types.hal

     *

     * Valid errors returned:

     *   RadioError:NONE must be returned on both success and failure of setup with the

     *              DataCallResponse.status containing the actual status

     *              For all other errors the DataCallResponse is ignored.

     *   RadioError:RADIO_NOT_AVAILABLE

     *   RadioError:OP_NOT_ALLOWED_BEFORE_REG_TO_NW

     *   RadioError:OP_NOT_ALLOWED_DURING_VOICE_CALL

     *   RadioError:REQUEST_NOT_SUPPORTED

     *   RadioError:INVALID_ARGUMENTS

     *   RadioError:INTERNAL_ERR

     *   RadioError:NO_MEMORY

     *   RadioError:NO_RESOURCES

     *   RadioError:CANCELLED

     *   RadioError:SIM_ABSENT

     */

    oneway setupDataCallResponse_1_4(RadioResponseInfo info, SetupDataCallResult dcResponse);

};

radio/1.4/types.hal

+1258 −11

File changed.

Preview size limit exceeded, changes collapsed.