Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 302ab9ef authored by Yu Shan's avatar Yu Shan
Browse files

Add trace to measure VHAL performance. 

Test: Manually run on emulator.
Bug: 269669729
Change-Id: I56b160b624c43d29aa85fffd28d1611fe63f7efc
parent 6d065549

automotive/vehicle/aidl/impl/fake_impl/hardware/src/FakeVehicleHardware.cpp

+10 −0
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 
 */



#define LOG_TAG "FakeVehicleHardware"

#define ATRACE_TAG ATRACE_TAG_HAL

#define FAKE_VEHICLEHARDWARE_DEBUG false  // STOPSHIP if true.



#include "FakeVehicleHardware.h"
@@ -33,6 +34,7 @@ 
#include <android-base/strings.h>

#include <utils/Log.h>

#include <utils/SystemClock.h>

#include <utils/Trace.h>



#include <dirent.h>

#include <inttypes.h>
@@ -1628,11 +1630,15 @@ void FakeVehicleHardware::PendingRequestHandler<FakeVehicleHardware::GetValuesCa 
    std::unordered_map<std::shared_ptr<const GetValuesCallback>, std::vector<GetValueResult>>

            callbackToResults;

    for (const auto& rwc : mRequests.flush()) {

        ATRACE_BEGIN("FakeVehicleHardware:handleGetValueRequest");

        auto result = mHardware->handleGetValueRequest(rwc.request);

        ATRACE_END();

        callbackToResults[rwc.callback].push_back(std::move(result));

    }

    for (const auto& [callback, results] : callbackToResults) {

        ATRACE_BEGIN("FakeVehicleHardware:call get value result callback");

        (*callback)(std::move(results));

        ATRACE_END();

    }

}
@@ -1642,11 +1648,15 @@ void FakeVehicleHardware::PendingRequestHandler<FakeVehicleHardware::SetValuesCa 
    std::unordered_map<std::shared_ptr<const SetValuesCallback>, std::vector<SetValueResult>>

            callbackToResults;

    for (const auto& rwc : mRequests.flush()) {

        ATRACE_BEGIN("FakeVehicleHardware:handleSetValueRequest");

        auto result = mHardware->handleSetValueRequest(rwc.request);

        ATRACE_END();

        callbackToResults[rwc.callback].push_back(std::move(result));

    }

    for (const auto& [callback, results] : callbackToResults) {

        ATRACE_BEGIN("FakeVehicleHardware:call set value result callback");

        (*callback)(std::move(results));

        ATRACE_END();

    }

}

automotive/vehicle/aidl/impl/vhal/src/DefaultVehicleHal.cpp

+4 −0
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 
 */



#define LOG_TAG "DefaultVehicleHal"

#define ATRACE_TAG ATRACE_TAG_HAL



#include <DefaultVehicleHal.h>
@@ -28,6 +29,7 @@ 
#include <private/android_filesystem_config.h>

#include <utils/Log.h>

#include <utils/SystemClock.h>

#include <utils/Trace.h>



#include <inttypes.h>

#include <set>
@@ -350,6 +352,7 @@ Result<void> DefaultVehicleHal::checkProperty(const VehiclePropValue& propValue) 


ScopedAStatus DefaultVehicleHal::getValues(const CallbackType& callback,

                                           const GetValueRequests& requests) {

    ATRACE_CALL();

    if (callback == nullptr) {

        return ScopedAStatus::fromExceptionCode(EX_NULL_POINTER);

    }
@@ -436,6 +439,7 @@ ScopedAStatus DefaultVehicleHal::getValues(const CallbackType& callback, 


ScopedAStatus DefaultVehicleHal::setValues(const CallbackType& callback,

                                           const SetValueRequests& requests) {

    ATRACE_CALL();

    if (callback == nullptr) {

        return ScopedAStatus::fromExceptionCode(EX_NULL_POINTER);

    }