Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26e1d731 authored by Ady Abraham's avatar Ady Abraham
Browse files

composer: VtsDisplay::setDimensions shouldn't be const 

Fix the usage of const attribute in VtsDisplay

Test: run composer 2.4 VTS
Bug: 185195256
Change-Id: I616ea044f46bc080ad0e82753b5031d9a38369f3
Merged-In: I616ea044f46bc080ad0e82753b5031d9a38369f3
parent 4a654833

graphics/composer/2.4/vts/functional/VtsHalGraphicsComposerV2_4TargetTest.cpp

+9 −9
Original line number Diff line number Diff line
@@ -71,15 +71,15 @@ class VtsDisplay { 


    IComposerClient::Rect getFrameRect() const { return {0, 0, mDisplayWidth, mDisplayHeight}; }



    void setDimensions(int32_t displayWidth, int32_t displayHeight) const {

    void setDimensions(int32_t displayWidth, int32_t displayHeight) {

        mDisplayWidth = displayWidth;

        mDisplayHeight = displayHeight;

    }



  private:

    const Display mDisplay;

    mutable int32_t mDisplayWidth;

    mutable int32_t mDisplayHeight;

    int32_t mDisplayWidth;

    int32_t mDisplayHeight;

};



class GraphicsComposerHidlTest : public ::testing::TestWithParam<std::string> {
@@ -198,7 +198,7 @@ class GraphicsComposerHidlTest : public ::testing::TestWithParam<std::string> { 
                                       const ContentType& contentType, const char* contentTypeStr);



    Error setActiveConfigWithConstraints(

            const VtsDisplay& display, Config config,

            VtsDisplay& display, Config config,

            const IComposerClient::VsyncPeriodChangeConstraints& constraints,

            VsyncPeriodChangeTimeline* timeline) {

        const auto error = mComposerClient->setActiveConfigWithConstraints(display.get(), config,
@@ -213,7 +213,7 @@ class GraphicsComposerHidlTest : public ::testing::TestWithParam<std::string> { 
        return error;

    }



    void setActiveConfig(const VtsDisplay& display, Config config) {

    void setActiveConfig(VtsDisplay& display, Config config) {

        mComposerClient->setActiveConfig(display.get(), config);

        const int32_t displayWidth = mComposerClient->getDisplayAttribute_2_4(

                display.get(), config, IComposerClient::Attribute::WIDTH);
@@ -322,7 +322,7 @@ TEST_P(GraphicsComposerHidlTest, getDisplayVsyncPeriod_BadDisplay) { 
}



TEST_P(GraphicsComposerHidlTest, getDisplayVsyncPeriod) {

    for (const auto& display : mDisplays) {

    for (VtsDisplay& display : mDisplays) {

        for (Config config : mComposerClient->getDisplayConfigs(display.get())) {

            VsyncPeriodNanos expectedVsyncPeriodNanos = mComposerClient->getDisplayAttribute_2_4(

                    display.get(), config,
@@ -386,7 +386,7 @@ TEST_P(GraphicsComposerHidlTest, setActiveConfigWithConstraints_BadConfig) { 
    constraints.seamlessRequired = false;

    constraints.desiredTimeNanos = systemTime();



    for (const auto& display : mDisplays) {

    for (VtsDisplay& display : mDisplays) {

        Config invalidConfigId = GetInvalidConfigId(display.get());

        EXPECT_EQ(Error::BAD_CONFIG,

                  setActiveConfigWithConstraints(display, invalidConfigId, constraints, &timeline));
@@ -400,7 +400,7 @@ TEST_P(GraphicsComposerHidlTest, setActiveConfigWithConstraints_SeamlessNotAllow 
    constraints.seamlessRequired = true;

    constraints.desiredTimeNanos = systemTime();



    for (const auto& display : mDisplays) {

    for (VtsDisplay& display : mDisplays) {

        forEachTwoConfigs(display.get(), [&](Config config1, Config config2) {

            const auto configGroup1 = mComposerClient->getDisplayAttribute_2_4(

                    display.get(), config1,
@@ -498,7 +498,7 @@ void GraphicsComposerHidlTest::waitForVsyncPeriodChange(Display display, 
}



void GraphicsComposerHidlTest::Test_setActiveConfigWithConstraints(const TestParameters& params) {

    for (const auto& display : mDisplays) {

    for (VtsDisplay& display : mDisplays) {

        forEachTwoConfigs(display.get(), [&](Config config1, Config config2) {

            setActiveConfig(display, config1);

            sendRefreshFrame(display, nullptr);