Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22a5ccd1 authored by David Drysdale's avatar David Drysdale Committed by Automerger Merge Worker
Browse files

Merge "KeyMint VTS: enable patchlevel checks" am: 8fb4a1c8

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1840175

Change-Id: I8b58efc55b884da16fe1312d571f42852ce642ff
parents bfeb55a6 8fb4a1c8
Loading
Loading
Loading
Loading
+6 −14
Original line number Diff line number Diff line
@@ -69,8 +69,6 @@ namespace aidl::android::hardware::security::keymint::test {

namespace {

bool check_patchLevels = false;

// The maximum number of times we'll attempt to verify that corruption
// of an ecrypted blob results in an error. Retries are necessary as there
// is a small (roughly 1/256) chance that corrupting ciphertext still results
@@ -529,14 +527,12 @@ class NewKeyGenerationTest : public KeyMintAidlTestBase {
        EXPECT_TRUE(os_pl);
        EXPECT_EQ(*os_pl, os_patch_level());

        if (check_patchLevels) {
        // Should include vendor and boot patchlevels.
        auto vendor_pl = auths.GetTagValue(TAG_VENDOR_PATCHLEVEL);
        EXPECT_TRUE(vendor_pl);
        EXPECT_EQ(*vendor_pl, vendor_patch_level());
        auto boot_pl = auths.GetTagValue(TAG_BOOT_PATCHLEVEL);
        EXPECT_TRUE(boot_pl);
        }

        return auths;
    }
@@ -6677,10 +6673,6 @@ int main(int argc, char** argv) {
            } else {
                std::cout << "NOT dumping attestations" << std::endl;
            }
            // TODO(drysdale): Remove this flag when available KeyMint devices comply with spec
            if (std::string(argv[i]) == "--check_patchLevels") {
                aidl::android::hardware::security::keymint::test::check_patchLevels = true;
            }
        }
    }
    return RUN_ALL_TESTS();