Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 160e4a1d authored Apr 22, 2022 by Sam Dubey

Revert "Fix use-after-free in GnssMesaurementInterface"

This reverts commit b6686e72.

Reason for revert: Broke LocationManagerFineTest

Bug: 230085457
Change-Id: Ic699cf1583dd9b858cb5dcd2545ca448a17def6e

parent b6686e72

gnss/aidl/default/Gnss.cpp

+1 −0

Original line number	Diff line number	Diff line
		@@ -153,6 +153,7 @@ void Gnss::reportSvStatus(const std::vector<GnssSvInfo>& svInfoList) const {

		std::vector<GnssSvInfo> Gnss::filterBlocklistedSatellites(
		std::vector<GnssSvInfo> gnssSvInfoList) const {
		ALOGD("filterBlocklistedSatellites");
		for (uint32_t i = 0; i < gnssSvInfoList.size(); i++) {
		if (mGnssConfiguration->isBlocklisted(gnssSvInfoList[i])) {
		gnssSvInfoList[i].svFlag &= ~(uint32_t)IGnssCallback::GnssSvFlags::USED_IN_FIX;

gnss/aidl/default/GnssMeasurementInterface.cpp

+1 −3

Original line number	Diff line number	Diff line
		@@ -106,14 +106,12 @@ void GnssMeasurementInterface::start(const bool enableCorrVecOutputs) {
		std::this_thread::sleep_for(std::chrono::milliseconds(mMinIntervalMillis));
		}
		});
		mThread.detach();
		}

		void GnssMeasurementInterface::stop() {
		ALOGD("stop");
		mIsActive = false;
		if (mThread.joinable()) {
		mThread.join();
		}
		}

		void GnssMeasurementInterface::reportMeasurement(const GnssData& data) {

gnss/aidl/default/GnssNavigationMessageInterface.cpp

+1 −3

Original line number	Diff line number	Diff line
		@@ -69,14 +69,12 @@ void GnssNavigationMessageInterface::start() {
		std::this_thread::sleep_for(std::chrono::milliseconds(mMinIntervalMillis));
		}
		});
		mThread.detach();
		}

		void GnssNavigationMessageInterface::stop() {
		ALOGD("stop");
		mIsActive = false;
		if (mThread.joinable()) {
		mThread.join();
		}
		}

		void GnssNavigationMessageInterface::reportMessage(const GnssNavigationMessage& message) {