Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f6b2608 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Remove use of ILLEGAL_ARGUMENT in hostEndpointDisconnected"

parents 7a8e9ac3 5dba9213

contexthub/aidl/android/hardware/contexthub/IContextHub.aidl

+2 −3
Original line number Diff line number Diff line
@@ -189,9 +189,8 @@ interface IContextHub { 
     * called, the HAL is expected to clean up any resources attached to the messaging channel

     * associated with this host endpoint ID.

     *

     * @param hostEndPointId The ID of the host that has disconnected.

     *

     * @throws EX_ILLEGAL_ARGUMENT if hostEndpointId is not associated with a connected host.

     * @param hostEndPointId The ID of the host that has disconnected. Any invalid values for this

     *                       parameter should be ignored (no-op).

     */

    void onHostEndpointDisconnected(char hostEndpointId);

contexthub/aidl/vts/VtsAidlHalContextHubTargetTest.cpp

+1 −2
Original line number Diff line number Diff line
@@ -338,8 +338,7 @@ TEST_P(ContextHubAidl, TestHostConnection) { 
TEST_P(ContextHubAidl, TestInvalidHostConnection) {

    constexpr char16_t kHostEndpointId = 1;



    Status status = contextHub->onHostEndpointDisconnected(kHostEndpointId);

    ASSERT_EQ(status.exceptionCode(), android::binder::Status::EX_ILLEGAL_ARGUMENT);

    ASSERT_TRUE(contextHub->onHostEndpointDisconnected(kHostEndpointId).isOk());

}



std::string PrintGeneratedTest(const testing::TestParamInfo<ContextHubAidl::ParamType>& info) {