Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b146168 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge changes Ia3b96e83,I80d924cc into pie-vts-dev 

* changes:
  Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
  Add SIM_PUK2 for Icc VTS tests
parents 2d86da7b 5fd0ccf7

current.txt

+1 −0
Original line number Diff line number Diff line
@@ -386,3 +386,4 @@ cd4330c3196bda1d642a32abfe23a7d64ebfbda721940643af6867af3b3f0aa9 android.hardwar 


# ABI preserving changes to HALs after Android P

1d19720d4fd38b1095f0f555a4bd92b3b12c9b1d0f560b0e9a474cd6dcc20db6 android.hardware.radio@1.2::IRadio

1d4a5776614c08b5d794a5ec5ab04697260cbd4b3441d5935cd53ee71d19da02 android.hardware.radio@1.0::IRadioResponse

radio/1.0/IRadioResponse.hal

+2 −0
Original line number Diff line number Diff line
@@ -88,6 +88,7 @@ interface IRadioResponse { 
     *   RadioError:INVALID_ARGUMENTS

     *   RadioError:INVALID_SIM_STATE

     *   RadioError:REQUEST_NOT_SUPPORTED

     *   RadioError:SIM_PUK2

     */

    oneway supplyIccPin2ForAppResponse(RadioResponseInfo info, int32_t remainingRetries);
@@ -141,6 +142,7 @@ interface IRadioResponse { 
     *   RadioError:INVALID_ARGUMENTS

     *   RadioError:INVALID_SIM_STATE

     *   RadioError:REQUEST_NOT_SUPPORTED

     *   RadioError:SIM_PUK2

     */

    oneway changeIccPin2ForAppResponse(RadioResponseInfo info, int32_t remainingRetries);

radio/1.0/vts/functional/radio_hidl_hal_icc.cpp

+11 −5
Original line number Diff line number Diff line
@@ -44,7 +44,9 @@ TEST_F(RadioHidlTest, supplyIccPinForApp) { 
            EXPECT_EQ(std::cv_status::no_timeout, wait());

            EXPECT_EQ(serial, radioRsp->rspInfo.serial);

            EXPECT_EQ(RadioResponseType::SOLICITED, radioRsp->rspInfo.type);

            EXPECT_EQ(RadioError::PASSWORD_INCORRECT, radioRsp->rspInfo.error);

            ASSERT_TRUE(CheckAnyOfErrors(

                radioRsp->rspInfo.error,

                {RadioError::PASSWORD_INCORRECT, RadioError::REQUEST_NOT_SUPPORTED}));

        }

    }

}
@@ -91,7 +93,10 @@ TEST_F(RadioHidlTest, supplyIccPin2ForApp) { 
            EXPECT_EQ(std::cv_status::no_timeout, wait());

            EXPECT_EQ(serial, radioRsp->rspInfo.serial);

            EXPECT_EQ(RadioResponseType::SOLICITED, radioRsp->rspInfo.type);

            EXPECT_EQ(RadioError::PASSWORD_INCORRECT, radioRsp->rspInfo.error);

            ASSERT_TRUE(

                CheckAnyOfErrors(radioRsp->rspInfo.error,

                                 {RadioError::PASSWORD_INCORRECT, RadioError::REQUEST_NOT_SUPPORTED,

                                  RadioError::SIM_PUK2}));

        }

    }

}
@@ -163,9 +168,10 @@ TEST_F(RadioHidlTest, changeIccPin2ForApp) { 
            EXPECT_EQ(std::cv_status::no_timeout, wait());

            EXPECT_EQ(serial, radioRsp->rspInfo.serial);

            EXPECT_EQ(RadioResponseType::SOLICITED, radioRsp->rspInfo.type);

            ASSERT_TRUE(CheckAnyOfErrors(

                radioRsp->rspInfo.error,

                {RadioError::PASSWORD_INCORRECT, RadioError::REQUEST_NOT_SUPPORTED}));

            ASSERT_TRUE(

                CheckAnyOfErrors(radioRsp->rspInfo.error,

                                 {RadioError::PASSWORD_INCORRECT, RadioError::REQUEST_NOT_SUPPORTED,

                                  RadioError::SIM_PUK2}));

        }

    }

}