Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 047484de authored by Shunkai Yao's avatar Shunkai Yao Committed by Gerrit Code Review
Browse files

Merge "Effect: verify all AIDL IEffect versions are same as IFactory" into main

parents cb49cde0 910a8153
Loading
Loading
Loading
Loading
+19 −0
Original line number Diff line number Diff line
@@ -296,6 +296,25 @@ TEST_P(EffectFactoryTest, QueryProcess) {
            [&](const auto& proc) { return processingSet.find(proc) != processingSet.end(); }));
}

// Make sure all effect instances have same HAL version number as IFactory.
TEST_P(EffectFactoryTest, VersionNumberForAllEffectsEqualsToIFactory) {
    std::vector<Descriptor> descs;
    EXPECT_IS_OK(mEffectFactory->queryEffects(std::nullopt, std::nullopt, std::nullopt, &descs));
    EXPECT_NE(descs.size(), 0UL);

    std::vector<std::shared_ptr<IEffect>> effects = createWithDescs(descs);
    int factoryVersion = 0;
    EXPECT_IS_OK(mEffectFactory->getInterfaceVersion(&factoryVersion));

    for (const auto& effect : effects) {
        int effectVersion = 0;
        EXPECT_NE(nullptr, effect);
        EXPECT_IS_OK(effect->getInterfaceVersion(&effectVersion));
        EXPECT_EQ(factoryVersion, effectVersion);
    }
    ASSERT_NO_FATAL_FAILURE(destroyEffects(effects));
}

INSTANTIATE_TEST_SUITE_P(EffectFactoryTest, EffectFactoryTest,
                         testing::ValuesIn(android::getAidlHalInstanceNames(IFactory::descriptor)),
                         android::PrintInstanceNameToString);