Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fecec7d7 authored by Wink Saville's avatar Wink Saville
Browse files

Fix NPE in SubscriptionController if getActiveSubscriptionInfoList is empty.

Bug: 18683935
Change-Id: I34a185a1585449bf8c7e9fe56672f2578753cc4d
parent 7a71b5bd
Loading
Loading
Loading
Loading
+20 −10
Original line number Diff line number Diff line
@@ -446,13 +446,18 @@ public class SubscriptionController extends ISub.Stub {
        enforceSubscriptionPermission();

        List<SubscriptionInfo> subList = getActiveSubscriptionInfoList();
        if (subList != null) {
            for (SubscriptionInfo si : subList) {
                if (si.getSubscriptionId() == subId) {
                    if (DBG) logd("[getActiveSubInfoForSubscriber]+ subId=" + subId + " subInfo=" + si);
                    return si;
                }
            }
        if (DBG) logd("[getActiveSubInfoForSubscriber]+ subId=" + subId + " subInfo=null");
        }
        if (DBG) {
            logd("[getActiveSubInfoForSubscriber]- subId=" + subId
                    + " subList=" + subList + " subInfo=null");
        }
        return null;
    }

@@ -466,13 +471,18 @@ public class SubscriptionController extends ISub.Stub {
        enforceSubscriptionPermission();

        List<SubscriptionInfo> subList = getActiveSubscriptionInfoList();
        if (subList != null) {
            for (SubscriptionInfo si : subList) {
                if (si.getIccId() == iccId) {
                    if (DBG) logd("[getActiveSubInfoUsingIccId]+ iccId=" + iccId + " subInfo=" + si);
                    return si;
                }
            }
        if (DBG) logd("[getActiveSubInfoUsingIccId]+ iccId=" + iccId + " subInfo=null");
        }
        if (DBG) {
            logd("[getActiveSubInfoUsingIccId]+ iccId=" + iccId
                    + " subList=" + subList + " subInfo=null");
        }
        return null;
    }