Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7a84596 authored by shilu's avatar shilu Committed by Shi Lu
Browse files

For API Review: getManualNetworkSelectionPlmn 

This method should return null instead of an empty

Bug: 148981244
Test: Manual
Change-Id: Ic7a2f5352e39d6f9bb3b36d64c9bd9aa7ad10399
parent 3560a0f1

src/java/com/android/internal/telephony/GsmCdmaPhone.java

+2 −2
Original line number Diff line number Diff line
@@ -176,7 +176,7 @@ public class GsmCdmaPhone extends Phone { 
    private SIMRecords mSimRecords;



    // For non-persisted manual network selection

    private String mManualNetworkSelectionPlmn = "";

    private String mManualNetworkSelectionPlmn;



    //Common

    // Instance Variables
@@ -1917,7 +1917,7 @@ public class GsmCdmaPhone extends Phone { 
            mManualNetworkSelectionPlmn = nsm.operatorNumeric;

        } else {

        //on Phone0 in emergency mode (no SIM), or in some races then clear the cache

            mManualNetworkSelectionPlmn = "";

            mManualNetworkSelectionPlmn = null;

            Rlog.e(LOG_TAG, "Cannot update network selection due to invalid subId "

                    + subId);

        }

src/java/com/android/internal/telephony/Phone.java

+1 −1
Original line number Diff line number Diff line
@@ -1943,7 +1943,7 @@ public abstract class Phone extends Handler implements PhoneInternalInterface { 
     *  Retrieves manually selected network info.

     */

    public String getManualNetworkSelectionPlmn() {

        return "";

        return null;

    }